Skip to content

docs: improve contributing deprecation notice #1367

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Snailedlt merged 1 commit into from
Sep 13, 2022
Merged

docs: improve contributing deprecation notice #1367

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions CONTRIBUTING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
<h1>Contributing to Devicon</h1>

<h2>This guide has been converted to a <a href="https://github.com/devicons/devicon/wiki">Wiki</a>! This document will eventually be removed, please use the Wiki instead.</h2>
<h2>This guide has been moved to the <a href="https://github.com/devicons/devicon/wiki">Wiki</a> and won't be updated any longer.</h2>
<br>
<p>
First of all, thanks for taking the time to contribute! This project can only grow and live by your countless contributions. To keep this project maintainable, we have developed some guidelines for our contributors.
Expand Down Expand Up @@ -503,4 +503,4 @@ We are running a Discord server. You can go here to talk, discuss, and more with
| Visual Studio Code | https://code.visualstudio.com/ | A code editor for editing code |
| vscode.dev | https://vscode.dev/ | Visual Studio Code in the browser |
| Iloveimg | https://www.iloveimg.com/resize-image/resize-svg | Resizing SVG's |
| svgviewer.dev | https://www.svgviewer.dev/ | View, save, and optimize SVGs |
| svgviewer.dev | https://www.svgviewer.dev/ | View, save, and optimize SVGs |
Copy link
Collaborator

@Snailedlt Snailedlt Aug 31, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see a change here. Could you point out what exactly changed on this line?

Copy link
Member Author

@Panquesito7 Panquesito7 Aug 31, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure about that, but I didn't make any changes there.

Copy link
Contributor

@BenSouchet BenSouchet Sep 4, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's maybe the line ending / line break, check https://stackoverflow.com/questions/1552749/difference-between-cr-lf-lf-and-cr-line-break-types

Copy link
Collaborator

@Snailedlt Snailedlt Sep 11, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll approve once this diff is fixed. Invisible changes always leave me with a bad taste in the mouth