new icon: hadoop (original, plain) #1438

MAGistR-bit · 2022-10-09T13:32:41Z

new icon: hadoop (original, plain)

This PR closes #584

Fix issue with npm publish script

Build preparation for release v2.15.1

The following actions were performed: * Updated devicon.json * Various versions of the icon have been added

MAGistR-bit · 2022-10-09T13:44:58Z

Hi! How long to wait for verification?

Snailedlt · 2022-10-09T20:21:10Z

Hi! How long to wait for verification?

Depends, usually it takes under a week before it's reviewed by at least one maintainer and just over a week before it's merged into develop

Snailedlt

A few things to sort out here, but the icons look good for the most part. I especially liked the line icon :)

package.json

package-lock.json

devicon.json

icons/hadoop/hadoop-line.svg

icons/hadoop/hadoop-original-wordmark.svg

icons/hadoop/hadoop-original.svg

Snailedlt · 2022-10-14T16:57:12Z

@MAGistR-bit Let me know if you need any help :)

The following actions were performed: * Updated devicon.json * Various versions of the icon have been added

The following changes have been made: * Updated the json file * Renamed the file * Deleted the file (hadoop-original-wordmark.svg)

The following changes have been made: * Optimized the images (SVG) * Merged the paths (for plain and line icons) into one

The following changes have been made: * Deleted extra files * Updated the file

Update devicon.json

MAGistR-bit · 2022-10-15T14:28:51Z

@MAGistR-bit Let me know if you need any help :)

Hello, @Snailedlt!
Made adjustments to the work:

I left two versions: original, plain.
I optimized the SVG code using SVGOMG.
Updated devicon.json.

P. S. I had errors when I submitted work to a remote repository, so I probably made unnecessary commits.

Snailedlt

Nice, you fixed a lot in those commits, well done! Don't worry about the extra commits, since it'll all be squashed when it's merged into develop.

Some changes are still needed in devicon.json, just apply the suggestions and it should be good.

hadoop-wordmark

I also found the official wordmark logo here: https://www.apache.org/logos/#hadoop
So we can add that to the PR too :)

Logo link 👇
https://svn.apache.org/repos/asf/comdev/project-logos/originals/hadoop.svg

Logo Preview 👇

devicon.json

Co-authored-by: Jørgen Kalsnes Hagen <43886029+Snailedlt@users.noreply.github.com>

Edited the color of the image

MAGistR-bit · 2022-10-21T14:06:24Z

@Snailedlt I have edited the color of the image (hadoop-original.svg).
In addition, I have applied your suggestions. Jørgen, did I do everything right?

You found the official wordmark logo, cool! 👍
Can we add this logo later?

devicon.json

github-actions · 2022-10-29T21:07:35Z

Hi there,

I'm Devicons' Peek Bot and it seems we've ran into a problem.

util.find_object_added_in_pr: Couldn't find an icon matching the name in the PR title.
PR title is: 'new icon:  hadoop (original, plain)'

Make sure that:

Your svgs are named and added correctly to the /icons folder as seen here.
Your icon information has been added to the devicon.json as seen here
Your PR title follows the format seen here

I will retry once everything is fixed. If I still fail or there are other error, the maintainers will investigate.

Best of luck,
Peek Bot ☺️

github-actions · 2022-10-29T21:13:06Z

Hi there,

I'm Devicons' Peek Bot and it seems we've ran into a problem.

util.find_object_added_in_pr: Couldn't find an icon matching the name in the PR title.
PR title is: 'new icon:  hadoop (original, plain)'

Make sure that:

Your svgs are named and added correctly to the /icons folder as seen here.
Your icon information has been added to the devicon.json as seen here
Your PR title follows the format seen here

I will retry once everything is fixed. If I still fail or there are other error, the maintainers will investigate.

Best of luck,
Peek Bot ☺️

github-actions · 2022-10-29T21:18:10Z

Hi there,

I'm Devicons' Peek Bot and it seems we've ran into a problem.

util.find_object_added_in_pr: Couldn't find an icon matching the name in the PR title.
PR title is: 'new icon:  hadoop (original, plain)'

Make sure that:

Your svgs are named and added correctly to the /icons folder as seen here.
Your icon information has been added to the devicon.json as seen here
Your PR title follows the format seen here

I will retry once everything is fixed. If I still fail or there are other error, the maintainers will investigate.

Best of luck,
Peek Bot ☺️

github-actions · 2022-10-29T21:23:42Z

Hi there,

I'm Devicons' Peek Bot and I just peeked at the icons that you wanted to add using icomoon.io.

Here are the SVGs as intepreted by Icomoon when we upload the files:

Here are the zoomed-in screenshots of the added icons as SVGs:

Here are the icons that will be generated by Icomoon:

Here are the zoomed-in screenshots of the added icons as icons:

Here are the colored versions:

The maintainers will now check for:

The number of Glyphs matches the number of SVGs that were selected.
The icons (second group of pictures) look the same as the SVGs (first group of pictures).
The icons are of high quality (legible, matches the official logo, etc.)

In case of font issues, it might be caused by Icomoon not accepting strokes in the SVGs. Check this doc for more details and fix the issues as instructed by Icomoon and update this PR once you are done.

Thank you for contributing to Devicon! I hope that your icons are accepted into the repository.

Note: If the images don't show up, it has been autodeleted by Imgur after 6 months due to our API choice.

Cheers,
Peek Bot 😊

Snailedlt · 2022-10-29T21:28:13Z

@MAGistR-bit I just reformated the devicon.json... looks good now. However I think we need to make a new PR, since the check-bot failed due to wrong PR title (there was an extra space), and it keeps using the old one even after I changed it.

So, please make a new PR. I'll be closing this one, and waiting for a new one to open. Thanks in advance 🙇

amacado and others added 4 commits March 22, 2022 22:31

Merge pull request devicons#1084 from devicons/develop

e7a43b9

Fix issue with npm publish script

bump npm version to v2.15.1

619c806

Merge pull request devicons#1085 from devicons/draft-release

1119b9f

Build preparation for release v2.15.1

new icon: hadoop (original, original-wordmark, line)

a28d5ad

The following actions were performed: * Updated devicon.json * Various versions of the icon have been added

Snailedlt requested changes Oct 9, 2022

View reviewed changes

Snailedlt added the feature:icon PR when a new icon is ready to be added to the collection label Oct 10, 2022

MAGistR-bit added 5 commits October 15, 2022 11:13

new icon: hadoop (original, original-wordmark, line)

54e70d2

The following actions were performed: * Updated devicon.json * Various versions of the icon have been added

new icon: original, plain

15debb6

The following changes have been made: * Updated the json file * Renamed the file * Deleted the file (hadoop-original-wordmark.svg)

new icon: original, plain

abef6b8

The following changes have been made: * Optimized the images (SVG) * Merged the paths (for plain and line icons) into one

Fixed the merge conflict

87bf329

new icon: hadoop (original, plain)

ba085d5

The following changes have been made: * Deleted extra files * Updated the file

MAGistR-bit changed the title ~~new icon: hadoop (original, original-wordmark, line)~~ new icon: hadoop (original, plain) Oct 15, 2022

new icon: hadoop (original, plain)

54cf51b

Update devicon.json

Snailedlt requested changes Oct 19, 2022

View reviewed changes

devicon.json Outdated Show resolved Hide resolved

MAGistR-bit and others added 2 commits October 21, 2022 16:01

Update devicon.json

3fe73e8

Co-authored-by: Jørgen Kalsnes Hagen <43886029+Snailedlt@users.noreply.github.com>

Update hadoop-original.svg

41acce1

Edited the color of the image

Snailedlt reviewed Oct 29, 2022

View reviewed changes

devicon.json Outdated Show resolved Hide resolved

Snailedlt added 2 commits October 29, 2022 23:05

fix devicon.json formatting

b885408

fix devicon.json formatting (again)

58daa78

Snailedlt added the bot:peek Trigger peek-bot. Remove and re-add the label to re-trigger label Oct 29, 2022

Snailedlt changed the title ~~new icon: hadoop (original, plain)~~ new icon: hadoop (original, plain) Oct 29, 2022

Snailedlt removed the bot:peek Trigger peek-bot. Remove and re-add the label to re-trigger label Oct 29, 2022

Snailedlt added the bot:peek Trigger peek-bot. Remove and re-add the label to re-trigger label Oct 29, 2022

Snailedlt closed this Oct 29, 2022

new icon: hadoop (original, plain) #1438

new icon: hadoop (original, plain) #1438

Uh oh!

Conversation

MAGistR-bit commented Oct 9, 2022 • edited by Snailedlt Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

MAGistR-bit commented Oct 9, 2022

Uh oh!

Snailedlt commented Oct 9, 2022

Uh oh!

Snailedlt left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Snailedlt commented Oct 14, 2022

Uh oh!

MAGistR-bit commented Oct 15, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Snailedlt left a comment

Choose a reason for hiding this comment

hadoop-wordmark

Uh oh!

Uh oh!

MAGistR-bit commented Oct 21, 2022

Uh oh!

Uh oh!

github-actions bot commented Oct 29, 2022

Uh oh!

github-actions bot commented Oct 29, 2022

Uh oh!

github-actions bot commented Oct 29, 2022

Uh oh!

github-actions bot commented Oct 29, 2022

Uh oh!

Snailedlt commented Oct 29, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

MAGistR-bit commented Oct 9, 2022 •

edited by Snailedlt

Loading

MAGistR-bit commented Oct 15, 2022 •

edited

Loading