-
Notifications
You must be signed in to change notification settings - Fork 2.4k
new icon: knexjs (original, original-wordmark, plain-wordmark) #1452
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Co-authored-by: David Leal <halfpacho@gmail.com>
Snailedlt
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suggest adding a javascript tag
Other than that this looks excellent 💯
Ohh and see if you can find a wordmark logo for this if possible.
I found this on google:
https://google.github.io/sqlcommenter/images/knex-logo.png
Which looks similar enough to the wordmark logos on their website:

Sadly it's a .png and not a .svg, so if you don't want to convert and add it (or make your own), that's okey too :)
|
Hi there, I'm Devicons' Peek Bot and I just peeked at the icons that you wanted to add using icomoon.io. Here are the SVGs as intepreted by Icomoon when we upload the files: Here are the zoomed-in screenshots of the added icons as SVGs: Here are the icons that will be generated by Icomoon: Here are the zoomed-in screenshots of the added icons as icons: Here are the colored versions: The maintainers will now check for:
In case of font issues, it might be caused by Icomoon not accepting strokes in the SVGs. Check this doc for more details and fix the issues as instructed by Icomoon and update this PR once you are done. Thank you for contributing to Devicon! I hope that your icons are accepted into the repository. Note: If the images don't show up, it has been autodeleted by Imgur after 6 months due to our API choice. Cheers, |
Co-authored-by: Jørgen Kalsnes Hagen <43886029+Snailedlt@users.noreply.github.com>
|
Hi there, I'm Devicons' Peek Bot and I just peeked at the icons that you wanted to add using icomoon.io. Here are the SVGs as intepreted by Icomoon when we upload the files: Here are the zoomed-in screenshots of the added icons as SVGs: Here are the icons that will be generated by Icomoon: Here are the zoomed-in screenshots of the added icons as icons: Here are the colored versions: The maintainers will now check for:
In case of font issues, it might be caused by Icomoon not accepting strokes in the SVGs. Check this doc for more details and fix the issues as instructed by Icomoon and update this PR once you are done. Thank you for contributing to Devicon! I hope that your icons are accepted into the repository. Note: If the images don't show up, it has been autodeleted by Imgur after 6 months due to our API choice. Cheers, |
Snailedlt
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All good!
Just saw that the library tag wasn't added though, so will approve once that's added :)
Good job on the PR
Co-authored-by: Jørgen Kalsnes Hagen <43886029+Snailedlt@users.noreply.github.com>
Snailedlt
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! ✔️
…ons#1452) * Add Ren'Py * Update devicon.json Co-authored-by: David Leal <halfpacho@gmail.com> * Add Knex.js * Add icons Add `original-wordmark` and `plain-wordmark` versions. * Update devicon.json Co-authored-by: Jørgen Kalsnes Hagen <43886029+Snailedlt@users.noreply.github.com> * Update devicon.json Co-authored-by: Jørgen Kalsnes Hagen <43886029+Snailedlt@users.noreply.github.com> Co-authored-by: David Leal <halfpacho@gmail.com> Co-authored-by: Jørgen Kalsnes Hagen <43886029+Snailedlt@users.noreply.github.com>














Double check these details before you open a PR
- PR does not match another non-stale PR currently opened
- PR name matches the format new icon: Icon name (versions separated by comma). More details here
- PR's base is the
- Your icons are inside a folder as seen here
- SVG matches the standards laid out here
- A new object is added in the
This PR closes #994developbranch.devicon.jsonfile as seen hereLink to prove your SVG is correct and up-to-date.
https://iconape.com/wp-content/files/bl/347262/svg/knexjs-seeklogo.com.svg