Add .editorconfig to VS Code extension recommendation
#1478
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix issue with npm publish script
Build preparation for release v2.15.1
daczarne
changed the title
.editorconfig to VS Code extension recommendation
Snailedlt
requested changes
Oct 23, 2022
Collaborator
Snailedlt
left a comment
Snailedlt
left a comment
There was a problem hiding this comment.
The changes to the recommendations look good (will have to double check locally though).
Before I can do a thorough review though, please remove the changes to package.json and package-lock.json.
In the future it's easier to just base your branch off of develop instead of master :)
daczarne
deleted the
add-editorconfig-to-vscode-extension-recommendation
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Double-check these details before you open a PR
Features
This PR added
.editrconfigto the list of recommended extensions for VS Code users.This PR closes #1143.
Notes
This PR should be merged to
masteralongside #1364.