Skip to content

Conversation

@theabhayprajapati
Copy link
Contributor

No description provided.

@theabhayprajapati
Copy link
Contributor Author

New TailwindCSS icons

added
image

and this one
image

Copy link
Collaborator

@Snailedlt Snailedlt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi there, thanks for making a PR!
Is this your first time contributing to devicons? :)
If so, please check out our wiki page on Updating An Icon

Here's some pointers as to what needs to be fixed first:

  • The PR base is master but should be develop
  • The PR title needs to be changed. Try re-creating the PR and adding ?quick_pull=1&template=new_icon.md to the end of the url before pressing create pull request
  • The icon filenames are invalid. See SVG-Versions for valid names

Let me know if you need any help, and feel free to join our discord if you prefer to chat there :)
https://discord.gg/Yp4wSU6sh4

@Snailedlt Snailedlt added the feature:icon PR when a new icon is ready to be added to the collection label Oct 31, 2022
@theabhayprajapati
Copy link
Contributor Author

@Snailedlt hey I have doubt 🤔 with the third point: which says file names are invalid as it should be SVG, however it's svg itself right now.
#1489

@Snailedlt
Copy link
Collaborator

@Snailedlt hey I have doubt 🤔 with the third point: which says file names are invalid as it should be SVG, however it's svg itself right now.
#1489

Sure, thanks for asking :)
The problem isn't the filetype, but the filename itself. It should follow the pattern described in the SVG-Versions I linked. I recommend reading through the wiki links I sent, to understand the process of making a PR :)

@theabhayprajapati
Copy link
Contributor Author

Hii 👋 @Snailedlt I read the wiki and your recommendation created a new PR while following the process.

@theabhayprajapati
Copy link
Contributor Author

#1493

@Snailedlt Snailedlt closed this Nov 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature:icon PR when a new icon is ready to be added to the collection

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants