Skip to content

Improve the issue templates #1515

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Panquesito7 merged 6 commits into from
Jan 31, 2023
Merged

Improve the issue templates #1515

Panquesito7 merged 6 commits into from
Jan 31, 2023

Conversation

@Snailedlt
Copy link
Collaborator

@Snailedlt Snailedlt commented Nov 19, 2022

Double check these details before you open a PR

  • PR does not match another non-stale PR currently opened

Features

Update issue templates, see #1467 for some reasons why this is useful

This PR closes #1467

Notes

@Snailedlt Snailedlt changed the title Feature/update issue templates Update issue templates Nov 19, 2022
@Snailedlt Snailedlt added devops Devops/automation related enhancements enhancement labels Nov 20, 2022
lunatic-fox
lunatic-fox requested changes Nov 28, 2022
View reviewed changes
Copy link
Contributor

@lunatic-fox lunatic-fox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think everything is ok, except for one modification. 🙂

@Panquesito7 Panquesito7 removed the devops Devops/automation related enhancements label Nov 28, 2022
Panquesito7
Panquesito7 requested changes Nov 28, 2022
View reviewed changes
Snailedlt and others added 3 commits November 28, 2022 07:18
@Snailedlt @Panquesito7
Update .github/ISSUE_TEMPLATE/icon_request.yml
a9054c1 
Co-authored-by: David Leal <halfpacho@gmail.com>
@Snailedlt @Panquesito7
Update .github/ISSUE_TEMPLATE/feature_request.yml
359494b 
Co-authored-by: David Leal <halfpacho@gmail.com>
@Snailedlt
Update .github/ISSUE_TEMPLATE/config.yml
a7df69c
@Panquesito7
Copy link
Member

Panquesito7 commented Nov 28, 2022

For some strange reason, there's a bug with the feature request template https://github.com/Snailedlt/devicon/blob/feature/update_issue_templates/.github/ISSUE_TEMPLATE/feature_request.yml
Same with the head repository https://github.com/devicons/devicon/blob/develop/.github/ISSUE_TEMPLATE/feature_request.yml

@Snailedlt
Copy link
Collaborator Author

Snailedlt commented Nov 28, 2022

@Panquesito7 hmm, nice catch! Might be a zerowidthspace, or some other whitespace character in there somewhere. I'll try to fix it.

@Snailedlt Snailedlt marked this pull request as draft December 12, 2022 07:29
@Snailedlt Snailedlt marked this pull request as ready for review January 9, 2023 18:17
@Snailedlt
Copy link
Collaborator Author

Snailedlt commented Jan 9, 2023

For some strange reason, there's a bug with the feature request template https://github.com/Snailedlt/devicon/blob/feature/update_issue_templates/.github/ISSUE_TEMPLATE/feature_request.yml Same with the head repository https://github.com/devicons/devicon/blob/develop/.github/ISSUE_TEMPLATE/feature_request.yml

@Panquesito7 I found the issue. It was just bad indentation... lol. Fixed in 44acc82

@Panquesito7 Panquesito7 added documentation Improvements or additions to documentation and removed enhancement labels Jan 31, 2023
Panquesito7
Panquesito7 approved these changes Jan 31, 2023
View reviewed changes
Copy link
Member

@Panquesito7 Panquesito7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome. Thanks! 🚀

@Panquesito7 Panquesito7 changed the title Update issue templates Improve the issue templates Jan 31, 2023
@Panquesito7 Panquesito7 merged commit 80aeaf8 into devicons:develop Jan 31, 2023
@Panquesito7 Panquesito7 linked an issue Jan 31, 2023 that may be closed by this pull request
[OTHER] Update the issue template for icon requests to be more detailed #1467
Closed
1 task
@Snailedlt Snailedlt mentioned this pull request Feb 5, 2024
Merged
GCHQDeveloper926 pushed a commit to GCHQDeveloper926/devicon that referenced this pull request Dec 20, 2024
@Snailedlt @Panquesito7
Improve the issue templates (devicons#1515)
810cd9a 
* Update issue templates for icon requests
fix devicons#1467

* Minor issue template refactorings

* Update .github/ISSUE_TEMPLATE/icon_request.yml

Co-authored-by: David Leal <halfpacho@gmail.com>

* Update .github/ISSUE_TEMPLATE/feature_request.yml

Co-authored-by: David Leal <halfpacho@gmail.com>

* Update .github/ISSUE_TEMPLATE/config.yml

* fix indenting

---------

Co-authored-by: David Leal <halfpacho@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Panquesito7 Panquesito7 Panquesito7 approved these changes

@lunatic-fox lunatic-fox lunatic-fox approved these changes

Assignees

No one assigned

Labels

documentation Improvements or additions to documentation

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[OTHER] Update the issue template for icon requests to be more detailed

3 participants

@Snailedlt @Panquesito7 @lunatic-fox