Skip to content

Conversation

@SubhamSubhasisPatra
Copy link

As per this issue #1611, Added the dynamodb svg.

@ConX
Copy link
Contributor

ConX commented Jan 5, 2023

Hi @SubhamSubhasisPatra, I think you will have to edit/resubmit your PR as you haven't included an updated devicon.json, and you haven't used the template in the PR. Check this for more details.

Disclaimer: I am also new to the project and not a maintainer.

@SubhamSubhasisPatra
Copy link
Author

Hi @ConX , Thanks for your feedback. I'll update the changes accordingly .

@ConX
Copy link
Contributor

ConX commented Jan 8, 2023

Hi @SubhamSubhasisPatra, I forgot to mention in my previous message that according to the instructions, the target repo of the PR must be the develop branch.

@lunatic-fox lunatic-fox changed the base branch from master to develop January 8, 2023 18:59
@lunatic-fox
Copy link
Contributor

lunatic-fox commented Jan 8, 2023

Hello there @SubhamSubhasisPatra!

Wish for the best! 😀

@SubhamSubhasisPatra
Copy link
Author

Hi @lunatic-fox and @ConX , Will make the changes . Thanks .

@Snailedlt Snailedlt added the feature:icon PR when a new icon is ready to be added to the collection label Jan 18, 2023
@dinbtechit
Copy link

Looks like this is the old AWS icons. Please use the new ones - https://aws.amazon.com/architecture/icons/

Here is the latest one:
image

@Snailedlt Snailedlt added the stale PRs that haven't had any activity for a while and old issues label Jan 30, 2023
@Snailedlt
Copy link
Collaborator

Duplicate of #1770
Which has already been merged to develop
Thank you for the contribution regardless!

@Snailedlt Snailedlt closed this Oct 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature:icon PR when a new icon is ready to be added to the collection stale PRs that haven't had any activity for a while and old issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants