-
Notifications
You must be signed in to change notification settings - Fork 2.4k
update icon: nano (original, plain, plain-wordmark) #1619
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Hi there, I'm Devicons' Peek Bot and it seems we've ran into a problem. Make sure that:
I will retry once everything is fixed. If I still fail or there are other error, the maintainers will investigate. Best of luck, |
|
Hi there, I'm Devicons' Peek Bot and I just peeked at the icons that you wanted to add using icomoon.io. Here are the SVGs as intepreted by Icomoon when we upload the files: Here are the zoomed-in screenshots of the added icons as SVGs: Here are the icons that will be generated by Icomoon: Here are the zoomed-in screenshots of the added icons as icons: Here are the colored versions: The maintainers will now check for:
In case of font issues, it might be caused by Icomoon not accepting strokes in the SVGs. Check this doc for more details and fix the issues as instructed by Icomoon and update this PR once you are done. Thank you for contributing to Devicon! I hope that your icons are accepted into the repository. Note: If the images don't show up, it has been autodeleted by Imgur after 6 months due to our API choice. Cheers, |
Snailedlt
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nano-original-wordmark.svg looks good, just need to be minified.
In the original issue you also mentioned that nano-original.svg has the same issue with icomoon, if that's the case, then that should be updated here too, right?
I am not sure what was wrong with the previous version. After exporting with Adobe Illustrator, it worked.
Hmm, odd. Great that it was easily fixable though! :D
|
@lunatic-fox I think the idea is good. Not ideal, but it's better than a crashing fontset. |
|
@lunatic-fox Both look good! I think the striped ones look better, but feel free to choose the one you like best here :) |
|
Hi there, I'm Devicons' Peek Bot and I just peeked at the icons that you wanted to add using icomoon.io. Here are the SVGs as intepreted by Icomoon when we upload the files: Here are the zoomed-in screenshots of the added icons as SVGs: Here are the icons that will be generated by Icomoon: Here are the zoomed-in screenshots of the added icons as icons: Here are the colored versions: The maintainers will now check for:
In case of font issues, it might be caused by Icomoon not accepting strokes in the SVGs. Check this doc for more details and fix the issues as instructed by Icomoon and update this PR once you are done. Thank you for contributing to Devicon! I hope that your icons are accepted into the repository. Note: If the images don't show up, it has been autodeleted by Imgur after 6 months due to our API choice. Cheers, |
Snailedlt
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! ✔️
Thank you for making the issue and PR @ConX and thank you for updating the plain icons @lunatic-fox
* Update nano icon to fix devicons#1613 * Add `plain` and `plain-wordmark` versions * Update nano-original-wordmark.svg --------- Co-authored-by: unknown <joseliojrx25@gmail.com> Co-authored-by: Josélio Júnior <76992016+lunatic-fox@users.noreply.github.com>
















Double check these details before you open a PR
Features
This PR closes NONE
Notes
I am not sure what was wrong with the previous version. After exporting with Adobe Illustrator, it worked.