Skip to content

Conversation

@Panquesito7
Copy link
Member

Double check these details before you open a PR

  • PR does not match another non-stale PR currently opened

Features

  • Darken a bit the website colors.
    • This fixes the issue of the invisible Devicon logo. It can be fixed by changing the background color manually or using a checkerboard (directly on the website), but I think we should have it fixed by default.

This PR closes #1434

Notes

Here you can see the old/new comparison screenshots

Current New
image image

This fixes the issue of the invisible Devicon logo.
It could be fixed by changing the background color manually, but I think we should have it fixed by default.
@Panquesito7 Panquesito7 added the bug Use this label for pointing out bugs label Feb 8, 2023
@Panquesito7 Panquesito7 requested a review from Snailedlt February 8, 2023 02:10
@Panquesito7 Panquesito7 linked an issue Feb 8, 2023 that may be closed by this pull request
1 task
Copy link
Contributor

@lunatic-fox lunatic-fox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm ok with this change to the next minor release. 🚀

@Panquesito7
Copy link
Member Author

So, should I merge this PR or wait 'till another release?
I think we can merge it now, IMO.

@Snailedlt
Copy link
Collaborator

Yeah, let's merge :)

@Snailedlt Snailedlt merged commit 714c453 into develop Feb 26, 2023
@Panquesito7 Panquesito7 deleted the panquesito7/improve/website_colors branch February 26, 2023 18:39
@Snailedlt Snailedlt mentioned this pull request Feb 5, 2024
GCHQDeveloper926 pushed a commit to GCHQDeveloper926/devicon that referenced this pull request Dec 20, 2024
This fixes the issue of the invisible Devicon logo.
It could be fixed by changing the background color manually, but I think we should have it fixed by default.

Co-authored-by: Jørgen Kalsnes Hagen <43886029+Snailedlt@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Use this label for pointing out bugs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] devicon SVG preview is invisible on the website

4 participants