-
Notifications
You must be signed in to change notification settings - Fork 2.4k
new icon: pypi (original, original-wordmark, plain, plain-wordmark) #1697
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Sorry for the delay on this one guys! My bad. If there is anything I need to change or add let me know. |
|
Hi! I'm the Check our CONTRIBUTING guide for more details regarding these errors. Please address these issues. When you update this PR, I will check your SVGs again. Thanks for your help, |
|
Hi! I'm the Check our CONTRIBUTING guide for more details regarding these errors. Please address these issues. When you update this PR, I will check your SVGs again. Thanks for your help, |
Snailedlt
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's a few things that need to be changed, so I'll give a brief overview here.
Read each comment for more info.
Some things that need to be fixed:
- Move
devicon.jsonobject to correct line, so that the file is alphabetically sorted - Add altnames in
devicon.json - Change to correct color in
devicon.json - Remove TM from original-wordmark
- Resize both icons to
viewbox="0 0 128 128"
Optional (recommended):
- Add
plainandplain-wordmarkversions - Add
lineandline-wordmarkversions
|
Hi! I'm the Check our CONTRIBUTING guide for more details regarding these errors. Please address these issues. When you update this PR, I will check your SVGs again. Thanks for your help, |
|
Hi! I'm the Check our CONTRIBUTING guide for more details regarding these errors. Please address these issues. When you update this PR, I will check your SVGs again. Thanks for your help, |
|
Hi! I'm the Check our CONTRIBUTING guide for more details regarding these errors. Please address these issues. When you update this PR, I will check your SVGs again. Thanks for your help, |
|
Hi there, I'm Devicons' Peek Bot and I just peeked at the icons that you wanted to add using icomoon.io. Here are the SVGs as intepreted by Icomoon when we upload the files: Here are the zoomed-in screenshots of the added icons as SVGs: Here are the icons that will be generated by Icomoon: Here are the zoomed-in screenshots of the added icons as icons: Here are the colored versions: The maintainers will now check for:
In case of font issues, it might be caused by Icomoon not accepting strokes in the SVGs. Check this doc for more details and fix the issues as instructed by Icomoon and update this PR once you are done. Thank you for contributing to Devicon! I hope that your icons are accepted into the repository. Note: If the images don't show up, it has been autodeleted by Imgur after 6 months due to our API choice. Cheers, |
Panquesito7
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! 🚀
Snailedlt
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work fixing all of the issues in one go 💯
Thank you for the contribution! ✔️
…evicons#1697) * Add pypi logos * Apply properly the SVGOMG * Fix minor issues on logos * Remove font and add color * Add altname * Change viewbox * Optimize icons and add `plain` and `plain-wordmark` versions * chore: apply suggestions from code review --------- Co-authored-by: “Juan <“juanernestobiondi@gmail.com”> Co-authored-by: Josélio Júnior <76992016+lunatic-fox@users.noreply.github.com> Co-authored-by: David Leal <halfpacho@gmail.com>








Double check these details before you open a PR
developbranch.devicon.jsonfile as seen hereThis PR closes #922
Link to prove your SVG is correct and up-to-date.