new icon: grpc (original, plain) #1751
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Panquesito7
added
the
feature:icon
lunatic-fox
requested changes
May 3, 2023
Contributor
lunatic-fox
left a comment
lunatic-fox
left a comment
There was a problem hiding this comment.
Suggestions based on: https://grpc.io/img/logos/grpc-logo.svg
original |
plain |
|---|---|
 |
 |
Changes:
originalgradient was preservedplainbased on contrast
@lunatic-fox format suggestions Co-authored-by: Josélio Júnior <76992016+lunatic-fox@users.noreply.github.com>
@lunatic-fox format suggestions Co-authored-by: Josélio Júnior <76992016+lunatic-fox@users.noreply.github.com>
Contributor
Author
|
I updated both based on @lunatic-fox's suggestions. |
Snailedlt
reviewed
May 4, 2023
Collaborator
Snailedlt
left a comment
Snailedlt
left a comment
There was a problem hiding this comment.
Looks good!
Only got an alt name suggestion, otherwise it's excellent
lunatic-fox
requested changes
May 4, 2023
Co-authored-by: Jørgen Kalsnes Hagen <43886029+Snailedlt@users.noreply.github.com>
Co-authored-by: Josélio Júnior <76992016+lunatic-fox@users.noreply.github.com>
lunatic-fox
approved these changes
May 16, 2023
Contributor
lunatic-fox
left a comment
lunatic-fox
left a comment
There was a problem hiding this comment.
Great! 🚀
Thank you for this contribution and @Panquesito7 for the screenshots! ✔
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Double check these details before you open a PR
developbranch.devicon.jsonfile as seen hereThis PR closes #467
Link to prove your SVG is correct and up-to-date.
https://grpc.io/img/logos/grpc-logo.png