new icon: ngrx (original, plain) #1753
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Snailedlt
requested changes
May 4, 2023
Collaborator
Snailedlt
left a comment
Snailedlt
left a comment
There was a problem hiding this comment.
Looks good!
Just a few small things to fix before it can be merged
Co-authored-by: Jørgen Kalsnes Hagen <43886029+Snailedlt@users.noreply.github.com>
Collaborator
|
@Panquesito7 Any idea why the checks are failing? |
Co-authored-by: Jørgen Kalsnes Hagen <43886029+Snailedlt@users.noreply.github.com>
Co-authored-by: Jørgen Kalsnes Hagen <43886029+Snailedlt@users.noreply.github.com>
lunatic-fox
changed the title
Add newline at the end of file.
Contributor
|
|
lunatic-fox
approved these changes
May 5, 2023
Contributor
lunatic-fox
left a comment
lunatic-fox
left a comment
There was a problem hiding this comment.
Looks good to me! ✔
Thank you for this contribution! 🚀
Member
Not sure, seems to be a CodeQL workflow issue, which should be reported separately. |
Panquesito7
approved these changes
May 13, 2023
Member
Panquesito7
left a comment
Panquesito7
left a comment
There was a problem hiding this comment.
Looks great. Thank you for contributing! 🚀
And thanks, @lunatic-fox, for the screenshots. 🙂
Panquesito7
added
the
feature:icon
Merged
GCHQDeveloper926
pushed a commit
to GCHQDeveloper926/devicon
that referenced
this pull request
Dec 20, 2024
* added ngrx original and plain icons * Update devicon.json Co-authored-by: Jørgen Kalsnes Hagen <43886029+Snailedlt@users.noreply.github.com> * Update devicon.json Co-authored-by: Jørgen Kalsnes Hagen <43886029+Snailedlt@users.noreply.github.com> * Update icons/ngrx/ngrx-plain.svg Co-authored-by: Jørgen Kalsnes Hagen <43886029+Snailedlt@users.noreply.github.com> * Fix `devicon.json` entry and optimize (minimize) icons * Update devicon.json Add newline at the end of file. --------- Co-authored-by: Jørgen Kalsnes Hagen <43886029+Snailedlt@users.noreply.github.com> Co-authored-by: Josélio Júnior <76992016+lunatic-fox@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Double check these details before you open a PR
developbranch.devicon.jsonfile as seen hereThis PR closes #1725
Link to prove your SVG is correct and up-to-date.
https://github.com/ngrx/platform/blob/0a13c4d89876f1ed399d2ec3cc46bda933a539b8/projects/ngrx.io/src/assets/images/badge.svg