Regenerate apple icon #177
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keiyasssss
approved these changes
Dec 1, 2019
amacado
added
the
feature:icon
debdutgoswami
approved these changes
Jun 8, 2020
amacado
reviewed
Jun 11, 2020
Member
amacado
left a comment
amacado
left a comment
There was a problem hiding this comment.
Thank you for regenerating the font and building the stylesheets. Since I'm on the way to restructure and clean up this repository, I will decline and close the pull request to recreate the css and the font when I'm done with reviewing/merging all pending pull requests. Still thank you for the idea of the default gulp task.
Comment on lines
+6
to
+7
| gulp.task('default', ['concat-css', 'minify-css']) | ||
|
|
Member
There was a problem hiding this comment.
Good idea! :) But since we updated to gulp 4 (#229) this syntax is no longer valid i think..
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I generate icon with icomoon, it seeams to fix squared off apple bug icon.