new icon: lodash (original, plain) #1879
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Snailedlt
requested changes
Oct 21, 2023
Collaborator
Snailedlt
left a comment
Snailedlt
left a comment
There was a problem hiding this comment.
Looking good! Padding on the icons should be removed here too :)
weh
force-pushed
the
feature/1837-add-lodash-icon
branch
from
ef5cd2d to
24d100e
Compare
Contributor
Author
|
Removed padding and rebased to |
weh
added
the
hacktoberfest-accepted
Snailedlt
requested review from
a team,
ConX,
canaleal and
lunatic-fox
and removed request for
a team
Snailedlt
added
the
feature:icon
lunatic-fox
requested changes
Nov 3, 2023
Contributor
lunatic-fox
left a comment
lunatic-fox
left a comment
There was a problem hiding this comment.
Great contribution! 👍🏼
Just some tiny adjustments. 🔧
remove #000 fill Co-authored-by: Josélio Júnior <76992016+lunatic-fox@users.noreply.github.com>
remove #000 fill Co-authored-by: Josélio Júnior <76992016+lunatic-fox@users.noreply.github.com>
lunatic-fox
approved these changes
Nov 9, 2023
Contributor
lunatic-fox
left a comment
lunatic-fox
left a comment
There was a problem hiding this comment.
Everything seems to be okay now! 👍🏼
Thank you for this contribution! 🚀
Collaborator
|
Merging this since it has two approvals :) |
Merged
GCHQDeveloper926
pushed a commit
to GCHQDeveloper926/devicon
that referenced
this pull request
Dec 20, 2024
* Add lodash icon * Remove padding * Update icons/lodash/lodash-original.svg remove #000 fill Co-authored-by: Josélio Júnior <76992016+lunatic-fox@users.noreply.github.com> * Update icons/lodash/lodash-plain.svg remove #000 fill Co-authored-by: Josélio Júnior <76992016+lunatic-fox@users.noreply.github.com> --------- Co-authored-by: Jørgen Kalsnes Hagen <43886029+Snailedlt@users.noreply.github.com> Co-authored-by: Josélio Júnior <76992016+lunatic-fox@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Double check these details before you open a PR
developbranch.devicon.jsonfile as seen hereThis PR closes #1837
Link to prove your SVG is correct and up-to-date.
https://lodash.com/