Skip to content

Conversation

@canaleal
Copy link
Member

@canaleal canaleal commented Oct 5, 2023

Double check these details before you open a PR

  • PR does not match another non-stale PR currently opened
  • PR name matches the format new icon: Icon name (versions separated by comma). More details here
  • PR's base is the develop branch.
  • Your icons are inside a folder as seen here
  • SVG matches the standards laid out here
  • A new object is added in the devicon.json file as seen here

This PR closes #1864

Link to prove your SVG is correct and up-to-date.

Official Site: https://www.pulumi.com/brand/
Github: https://github.com/pulumi/pulumi

I used Pulumi base yellow (#f6bf29) for plain and plain-wordmark.

I was working on this a while back. Only a few minutes ago, another pull request (#1881) was created but it does not include wordmark or plains. We could merge both requests.

@weh weh mentioned this pull request Oct 5, 2023
7 tasks
Copy link

@desteves desteves left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! TY for putting this together <3

@weh
Copy link
Contributor

weh commented Oct 9, 2023

I think the plain and plain-wordmark files need to have one unified path see SVG-Standards

@canaleal
Copy link
Member Author

canaleal commented Oct 9, 2023

💀 @weh You're right. Will get on it right away and fix the problem.

Copy link
Collaborator

@Snailedlt Snailedlt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!
Thank you for your contribution! 💯

@Snailedlt Snailedlt requested review from a team, ConX and lunatic-fox and removed request for a team October 21, 2023 14:02
@Snailedlt Snailedlt added the hacktoberfest-accepted Accepted to be counted towards Hacktoberfest label Oct 21, 2023
Copy link
Contributor

@ConX ConX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @canaleal!

@Snailedlt Snailedlt merged commit 20cdaa5 into devicons:develop Oct 22, 2023
@Snailedlt Snailedlt added the feature:icon PR when a new icon is ready to be added to the collection label Nov 5, 2023
@Snailedlt Snailedlt mentioned this pull request Feb 5, 2024
GCHQDeveloper926 pushed a commit to GCHQDeveloper926/devicon that referenced this pull request Dec 20, 2024
…devicons#1882)

* Added pulumi icon

* Updated Plain SVGs to use unified path and fill

---------

Co-authored-by: Jørgen Kalsnes Hagen <43886029+Snailedlt@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature:icon PR when a new icon is ready to be added to the collection hacktoberfest-accepted Accepted to be counted towards Hacktoberfest

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants