Skip to content

Conversation

@canaleal
Copy link
Member

@canaleal canaleal commented Oct 5, 2023

Double check these details before you open a PR

  • PR does not match another non-stale PR currently opened
  • PR name matches the format new icon: Icon name (versions separated by comma). More details here
  • PR's base is the develop branch.
  • Your icons are inside a folder as seen here
  • SVG matches the standards laid out here
  • A new object is added in the devicon.json file as seen here

This PR closes #1830

Link to prove your SVG is correct and up-to-date.

I tried finding an icon with a wordmark but there's nothing official.
I used the #df1c85 color from the original RxJS icon for the plain icon.

Main Website: https://rxjs.dev/
Github: https://github.com/ReactiveX/rxjs

Copy link
Collaborator

@Snailedlt Snailedlt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! ✔️
Thank you for the contribution! 🙇

@Snailedlt Snailedlt requested review from a team, ConX, Panquesito7 and lunatic-fox and removed request for a team October 21, 2023 14:04
@Snailedlt Snailedlt added the hacktoberfest-accepted Accepted to be counted towards Hacktoberfest label Oct 21, 2023
Copy link
Contributor

@lunatic-fox lunatic-fox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks great! 👍🏼
Thank you for this contribution! 🚀

@lunatic-fox
Copy link
Contributor

image

@Snailedlt Snailedlt merged commit 5d2ea2e into devicons:develop Oct 26, 2023
@Snailedlt Snailedlt added the feature:icon PR when a new icon is ready to be added to the collection label Nov 5, 2023
@Snailedlt Snailedlt mentioned this pull request Feb 5, 2024
GCHQDeveloper926 pushed a commit to GCHQDeveloper926/devicon that referenced this pull request Dec 20, 2024
* Added rxjs icon

* Added new lines and unified paths for plain svg

---------

Co-authored-by: Jørgen Kalsnes Hagen <43886029+Snailedlt@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature:icon PR when a new icon is ready to be added to the collection hacktoberfest-accepted Accepted to be counted towards Hacktoberfest

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants