new icon: carbon (original) #1899
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Snailedlt
requested changes
Oct 21, 2023
Collaborator
Snailedlt
left a comment
Snailedlt
left a comment
There was a problem hiding this comment.
Thank you for another great contribution! 💯 🙇
Again, I just suggested a small change for the icon, once that's added it's all good!
Co-authored-by: Jørgen Kalsnes Hagen <43886029+Snailedlt@users.noreply.github.com>
weh
force-pushed
the
feature/1895-add-carbon-icon
branch
from
8bdd8ef to
6bdb840
Compare
weh
added
the
hacktoberfest-accepted
Snailedlt
requested review from
a team,
ConX,
canaleal and
lunatic-fox
and removed request for
a team
canaleal
approved these changes
Oct 23, 2023
Member
canaleal
left a comment
canaleal
left a comment
There was a problem hiding this comment.
Devicon.json is great, and the SVG is optimized/ uses hex fill. Nice nice.
Snailedlt
added
the
feature:icon
Merged
GCHQDeveloper926
pushed a commit
to GCHQDeveloper926/devicon
that referenced
this pull request
Dec 20, 2024
* Add icon: carbon (original) * Change fill to hex Co-authored-by: Jørgen Kalsnes Hagen <43886029+Snailedlt@users.noreply.github.com> --------- Co-authored-by: Jørgen Kalsnes Hagen <43886029+Snailedlt@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Double check these details before you open a PR
developbranch.devicon.jsonfile as seen hereThis PR closes
closes #1895
Link to prove your SVG is correct and up-to-date.
https://github.com/carbon-language/carbon-lang