Skip to content

[FEAT]: "New Twitter Icon" #1909

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Yashh56 wants to merge 2 commits into from
Closed

[FEAT]: "New Twitter Icon" #1909

Yashh56 wants to merge 2 commits into from

Conversation

@Yashh56
Copy link
Contributor

@Yashh56 Yashh56 commented Oct 18, 2023

Adding a New Twitter Icon #1890

lunatic-fox and others added 2 commits September 1, 2023 15:46
@lunatic-fox
Fix build icons workflow (#1840)
55609aa 
* Fix build icons workflow

* Moving Build Icons to Ubuntu machine
@Yashh56
"New Twitter Icon"
1088d02
@Yashh56 Yashh56 changed the base branch from master to develop October 18, 2023 12:31
@Yashh56
Copy link
Contributor Author

Yashh56 commented Oct 18, 2023

Hey Maintainers Please Review the PR

Snailedlt
Snailedlt requested changes Oct 18, 2023
View reviewed changes
Copy link
Collaborator

@Snailedlt Snailedlt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please base your branch on the develop branch so that you don't get all of these conflicts. If you do that correctly you should see no changes to the build_icons workflow
Once that's done, please add x as an altname to twitter in devicon.json

@Yashh56
Copy link
Contributor Author

Yashh56 commented Oct 18, 2023

Is there is problem in this branch? it is merging the file in develop branch of devicons.

@Yashh56
Copy link
Contributor Author

Yashh56 commented Oct 18, 2023

should I change the name of Twitter? @Snailedlt

@Snailedlt
Copy link
Collaborator

Snailedlt commented Oct 18, 2023

Is there is problem in this branch? it is merging the file in develop branch of devicons.

Yes. The PR is set to merge into develop, but the branch had commits from the master branch. To fix this you can either revert the commit or make a new branch from the develop brnach and apply the changes on that. Whichever is easier for you :)

The name should be twitter, but you can add x as an altname (see the wiki for how to edit devicon.json)

This was referenced Oct 19, 2023
Merged
Closed
@Yashh56 Yashh56 requested a review from Snailedlt October 19, 2023 10:52
@Yashh56
Copy link
Contributor Author

Yashh56 commented Oct 19, 2023

Hey Maintainers Please Review the PR !!

@Snailedlt
Copy link
Collaborator

Snailedlt commented Oct 19, 2023

Duplicate of #1912

@Snailedlt Snailedlt marked this as a duplicate of #1912 Oct 19, 2023
@Snailedlt Snailedlt closed this Oct 19, 2023
@Yashh56 Yashh56 deleted the feat/New-Twitter-Icon branch February 6, 2024 03:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Snailedlt Snailedlt Awaiting requested review from Snailedlt

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Yashh56 @Snailedlt @lunatic-fox