Skip to content

Conversation

@canaleal
Copy link
Member

Double check these details before you open a PR

  • PR does not match another non-stale PR currently opened
  • PR name matches the format new icon: Icon name (versions separated by comma). More details here
  • PR's base is the develop branch.
  • Your icons are inside a folder as seen here
  • SVG matches the standards laid out here
  • A new object is added in the devicon.json file as seen here

This PR closes #1637

Link to prove your SVG is correct and up-to-date.

The Spyder logo makes use of the color #8c0000 and a dark gray #303030. I went with red as it ss the most prominent color on the Spyder website, and is used in the other Spyder logos/ tools.

Copy link
Contributor

@weh weh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@weh weh requested review from a team, ConX, Snailedlt and lunatic-fox and removed request for a team October 24, 2023 09:18
@weh weh added the hacktoberfest-accepted Accepted to be counted towards Hacktoberfest label Oct 24, 2023
Copy link
Collaborator

@Snailedlt Snailedlt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! ✔️
Thank you for another great contribution! 💯 🙇

PS: It would be really nice if you tried adding some line icons too. It's super simple, you can just follow the tutorial here: #1306 (comment)
Let us know if you need help with it :)

@Snailedlt Snailedlt merged commit 2cba34d into devicons:develop Oct 24, 2023
@Snailedlt Snailedlt added the feature:icon PR when a new icon is ready to be added to the collection label Nov 5, 2023
@Snailedlt Snailedlt mentioned this pull request Feb 5, 2024
GCHQDeveloper926 pushed a commit to GCHQDeveloper926/devicon that referenced this pull request Dec 20, 2024
Co-authored-by: Jørgen Kalsnes Hagen <43886029+Snailedlt@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature:icon PR when a new icon is ready to be added to the collection hacktoberfest-accepted Accepted to be counted towards Hacktoberfest

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants