Skip to content

Conversation

@canaleal
Copy link
Member

@canaleal canaleal commented Nov 3, 2023

Double check these details before you open a PR

  • PR does not match another non-stale PR currently opened
  • PR name matches the format new icon: Icon name (versions separated by comma). More details here
  • PR's base is the develop branch.
  • Your icons are inside a folder as seen here
  • SVG matches the standards laid out here
  • A new object is added in the devicon.json file as seen here

This PR closes #1466

Link to prove your SVG is correct and up-to-date.

The original Vulkan SVG can also serve as a wordmark SVG. The original SVG is also simple enough to be used a Plain Icon.
The line SVG can also be used for the line-wordmark SVG.

Original SVG = original-wordmark, plain, plain-wordmark
Line SVG = line-wordmark

As for colors I went with #ac162c as it's the only color used in the original SVG.

@canaleal canaleal added the feature:icon PR when a new icon is ready to be added to the collection label Nov 3, 2023
Copy link
Contributor

@weh weh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@weh weh requested review from a team, ConX, Snailedlt and lunatic-fox and removed request for a team November 13, 2023 17:04
@github-actions
Copy link
Contributor

Hi!

I'm the check-bot and we have some issues with your PR:

devicon.json is not sorted correctly.
Please make sure that your icon is added in the `devicon.json` file at the correct alphabetic position
as seen here: https://github.com/devicons/devicon/wiki/Updating-%60devicon.json%60


Check our CONTRIBUTING guide for more details regarding these errors.

Please address these issues. When you update this PR, I will check your SVGs again.

Thanks for your help,
SVG-Checker Bot 😄

@github-actions
Copy link
Contributor

github-actions bot commented Dec 1, 2024

Hi!

I'm the check-bot and we have some issues with your PR:

devicon.json is not sorted correctly.
Please make sure that your icon is added in the `devicon.json` file at the correct alphabetic position
as seen here: https://github.com/devicons/devicon/wiki/Updating-%60devicon.json%60


Check our CONTRIBUTING guide for more details regarding these errors.

Please address these issues. When you update this PR, I will check your SVGs again.

Thanks for your help,
SVG-Checker Bot 😄

@canaleal canaleal merged commit df4e8bd into devicons:develop Dec 1, 2024
5 checks passed
GCHQDeveloper926 pushed a commit to GCHQDeveloper926/devicon that referenced this pull request Dec 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature:icon PR when a new icon is ready to be added to the collection

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants