Skip to content

Conversation

@lunatic-fox
Copy link
Contributor

Double check these details before you open a PR

  • PR does not match another non-stale PR currently opened

Features

This pull request fix errors of reference in devicon.json file for each of icons listed below:

  • capacitor
  • elasticsearch
  • heroku
  • hibernate
  • jaegertracing
  • karatelabs
  • kibana
  • ktor
  • livewire
  • llvm
  • logstash
  • nginx
  • nhibernate
  • okta
  • opentelemetry
  • postman
  • quarkus
  • quasar
  • sqldeveloper
  • unidifimodelinglanguage

This PR closes NONE

Notes

Some icons were not displayed purely because of reference errors in devicon.json file.

Copy link
Contributor

@weh weh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.
i guess this is also part of the release preparation for v2.16.0
#1900, #1998

@Panquesito7 Panquesito7 added the devops Devops/automation related enhancements label Nov 14, 2023
Copy link
Member

@Panquesito7 Panquesito7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work! Thank you. 🚀
Now I was thinking if we could make some sort of script that validates the devicon.json file to make sure everything's correct and then incorporate it into GitHub Actions to prevent these problems.

@Panquesito7 Panquesito7 merged commit b318264 into devicons:develop Nov 14, 2023
@Snailedlt
Copy link
Collaborator

Snailedlt commented Nov 14, 2023

Awesome work! Thank you. 🚀
Now I was thinking if we could make some sort of script that validates the devicon.json file to make sure everything's correct and then incorporate it into GitHub Actions to prevent these problems.

Iirc we have something like that on the develop branch, and I think I remember something like that in an unmerged PR by weh or ConX too

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

devops Devops/automation related enhancements

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants