-
Notifications
You must be signed in to change notification settings - Fork 2.4k
new icon: chartjs (original, original-wordmark, plain, plain-wordmark) #2003
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
canaleal
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, thank you for the contribution.
Just optimized and combined the plain svg paths.
2d27cf6 to
178f8ad
Compare
|
optimized with correct svgomg options this time, and rebased to current develop branch |
canaleal
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great stuff. LGTM
c5f9fc5 to
35aeaec
Compare
|
Hi! I'm the Check our CONTRIBUTING guide for more details regarding these errors. Please address these issues. When you update this PR, I will check your SVGs again. Thanks for your help, |
canaleal
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent work.
new icon: chartjs (original, original-wordmark, plain, plain-wordmark)
Double check these details before you open a PR
developbranch.devicon.jsonfile as seen hereThis PR closes
closes #1822
Link to prove your SVG is correct and up-to-date.
https://www.chartjs.org/