Skip to content

Conversation

@femsci
Copy link
Contributor

@femsci femsci commented Nov 16, 2023

Double check these details before you open a PR

  • PR does not match another non-stale PR currently opened
  • PR name matches the format new icon: Icon name (versions separated by comma). More details here
  • PR's base is the develop branch.
  • Your icons are inside a folder as seen here
  • SVG matches the standards laid out here
  • A new object is added in the devicon.json file as seen here

This PR closes #2008

Link to prove your SVG is correct and up-to-date.

https://gitea.artixlinux.org/artix/artwork/src/branch/master/icons

logo

SVGs stripped for size

Copy link
Member

@canaleal canaleal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @femsci,excellent work on the SVGs and Json!

There appears to be a little bit of padding left on all the SVGs; If possible, could you resize the SVGs so they reach the edges of the viewbox and then optimize the SVG code as shown in this tutorial.

image

@canaleal canaleal added the feature:icon PR when a new icon is ready to be added to the collection label Nov 18, 2023
@canaleal
Copy link
Member

Hey @femsci, I just wanted to leave a note.

This small tutorial shows how to align the SVGs to remove the padding and how to use SVGOMG to optimize and clean up the SVGs.

@github-actions
Copy link
Contributor

Hi!

I'm the check-bot and we have some issues with your PR:

devicon.json is not sorted correctly.
Please make sure that your icon is added in the `devicon.json` file at the correct alphabetic position
as seen here: https://github.com/devicons/devicon/wiki/Updating-%60devicon.json%60


Check our CONTRIBUTING guide for more details regarding these errors.

Please address these issues. When you update this PR, I will check your SVGs again.

Thanks for your help,
SVG-Checker Bot 😄

Copy link
Member

@canaleal canaleal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's been some time since any changes have been made so I optimized the SVGs and fixed their alignment.

There are no artifacts in icomoon.

image

@github-actions
Copy link
Contributor

Hi!

I'm the check-bot and we have some issues with your PR:

devicon.json is not sorted correctly.
Please make sure that your icon is added in the `devicon.json` file at the correct alphabetic position
as seen here: https://github.com/devicons/devicon/wiki/Updating-%60devicon.json%60


Check our CONTRIBUTING guide for more details regarding these errors.

Please address these issues. When you update this PR, I will check your SVGs again.

Thanks for your help,
SVG-Checker Bot 😄

@canaleal canaleal merged commit ee9d77d into devicons:develop Dec 23, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature:icon PR when a new icon is ready to be added to the collection

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants