Skip to content

Conversation

@AnshSinghSonkhia
Copy link
Contributor

@AnshSinghSonkhia AnshSinghSonkhia commented Jan 29, 2024

Double check these details before you open a PR

  • PR does not match another non-stale PR currently opened
  • PR name matches the format new icon: Icon name (versions separated by comma). More details here
  • PR's base is the develop branch.
  • Your icons are inside a folder as seen here
  • SVG matches the standards laid out here
  • A new object is added in the devicon.json file as seen here

This PR closes #2120

Link to prove your SVG is correct and up-to-date.

https://filamentphp.com/

Copy link
Member

@canaleal canaleal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, here are few changes that are needed:

  • Instead of plain-wordmark call the SVG original as the icon you added is the original filamentphp logo.
  • Optimize and clean up the SVG like we did in the remix pr. Because the SVG only has 1 color, you can combine the paths into 1 path; This reduces the size of the svg and makes it possible for us the svg as an base/ alias for other version.
  • Because there is only 1 path and fill color you can use the filamentphp-original.svg as the base and make aliases for original-wordmark, plain, and plain-wordmark.

@AnshSinghSonkhia AnshSinghSonkhia changed the title new icon: filamentphp (plain-wordmark) new icon: filamentphp (original) Mar 8, 2024
using InkScape, SVGOMG, SVGviewer
@AnshSinghSonkhia
Copy link
Contributor Author

  • Instead of plain-wordmark call the SVG original as the icon you added is the original filamentphp logo.
  • Optimize and clean up the SVG like we did in the remix pr. Because the SVG only has 1 color, you can combine the paths into 1 path; This reduces the size of the svg and makes it possible for us the svg as an base/ alias for other version.

These changes are done!!

@AnshSinghSonkhia
Copy link
Contributor Author

  • Because there is only 1 path and fill color you can use the filamentphp-original.svg as the base and make aliases for original-wordmark, plain, and plain-wordmark.

Made some changes in devicon.json

"aliases": [
            {
                "base": "original",
                "alias": [
                    "original-wordmark",
                    "plain",
                    "plain-wordmark"
                ]
            }
        ]

Kindly. verify it @canaleal

@canaleal
Copy link
Member

canaleal commented Mar 8, 2024

By the way, the SVG has a fill="currentColor" and class="transition duration-300 will-change-transform group-hover/filament:-translate-x-[1.2rem] motion-reduce:transition-none" that can be removed.

Removed:

fill="currentColor",
class="transition duration-300 will-change-transform group-hover/filament:-translate-x-[1.2rem] motion-reduce:transition-none"
@AnshSinghSonkhia
Copy link
Contributor Author

By the way, the SVG has a fill="currentColor" and class="transition duration-300 will-change-transform group-hover/filament:-translate-x-[1.2rem] motion-reduce:transition-none" that can be removed.

Done, anymore changes required?

@github-actions
Copy link
Contributor

github-actions bot commented Mar 9, 2024

Hi!

I'm the check-bot and we have some issues with your PR:

devicon.json is not sorted correctly.
Please make sure that your icon is added in the `devicon.json` file at the correct alphabetic position
as seen here: https://github.com/devicons/devicon/wiki/Updating-%60devicon.json%60


Check our CONTRIBUTING guide for more details regarding these errors.

Please address these issues. When you update this PR, I will check your SVGs again.

Thanks for your help,
SVG-Checker Bot 😄

@github-actions
Copy link
Contributor

github-actions bot commented Mar 9, 2024

Hi!

I'm the check-bot and we have some issues with your PR:

devicon.json is not sorted correctly.
Please make sure that your icon is added in the `devicon.json` file at the correct alphabetic position
as seen here: https://github.com/devicons/devicon/wiki/Updating-%60devicon.json%60


Check our CONTRIBUTING guide for more details regarding these errors.

Please address these issues. When you update this PR, I will check your SVGs again.

Thanks for your help,
SVG-Checker Bot 😄

Copy link
Member

@canaleal canaleal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect 👍 🦖

I added any empty altnames array to the json and updated the svg paths a little so there are no line artifacts in icomoon

image

@Snailedlt Snailedlt added the feature:icon PR when a new icon is ready to be added to the collection label Jul 1, 2024
@canaleal canaleal requested review from a team, ConX, Snailedlt, lunatic-fox and weh and removed request for a team September 8, 2024 04:10
Copy link
Collaborator

@Snailedlt Snailedlt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great use of aliases! 💯
Thank you for your contribution! 🙇‍♂️

@github-actions
Copy link
Contributor

Hi!

I'm the check-bot and we have some issues with your PR:

devicon.json is not sorted correctly.
Please make sure that your icon is added in the `devicon.json` file at the correct alphabetic position
as seen here: https://github.com/devicons/devicon/wiki/Updating-%60devicon.json%60


Check our CONTRIBUTING guide for more details regarding these errors.

Please address these issues. When you update this PR, I will check your SVGs again.

Thanks for your help,
SVG-Checker Bot 😄

@Snailedlt Snailedlt merged commit fc89139 into devicons:develop Sep 12, 2024
GCHQDeveloper926 pushed a commit to GCHQDeveloper926/devicon that referenced this pull request Dec 20, 2024
* Create a

* Added Icon: filamentphp (Plain-wordmark)

* Removed test file

* Update devicon.json with filamentphp icon

* Updated: devicon.json with aliases

* Optimized & Rename: filamentphp-original.svg

using InkScape, SVGOMG, SVGviewer

* Updated aliases in devicon.json

* Removed unnecessary fill & class tags

Removed:

fill="currentColor",
class="transition duration-300 will-change-transform group-hover/filament:-translate-x-[1.2rem] motion-reduce:transition-none"

* Added emptry altnames to devicon.json

* Updated filamentphp-original.svg to get rid of icomoon line artifacts.

---------

Co-authored-by: Alex Canales <49886351+canaleal@users.noreply.github.com>
Co-authored-by: Jørgen Kalsnes Hagen <43886029+Snailedlt@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature:icon PR when a new icon is ready to be added to the collection

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants