Skip to content

Icon change: Flutter foundation change #335

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ezSaldana wants to merge 3 commits into from
Closed

Icon change: Flutter foundation change #335

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
35a2968
Merged with develop branch and updated json file, added flutter. Dele…
ezSaldana Oct 22, 2020
b4efe07
deleted font plain-wordmark from json file
ezSaldana Oct 22, 2020
999971f
Changed flutter foundation color
ezSaldana Oct 24, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 20 additions & 3 deletions devicon.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -925,6 +925,24 @@
"color": "#DD732A",
"aliases": []
},
{
"name": "flutter",
"tags": [
"framework",
"sdk"
],
"versions": {
"svg": [
"original",
"plain"
],
"font": [
"plain"
]
},
"color": "#3FB6D3",
"aliases": []
},
Comment on lines +928 to +945
Copy link
Member

@amacado amacado Oct 24, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Flutter is added in #296

Suggested change
{
"name": "flutter",
"tags": [
"framework",
"sdk"
],
"versions": {
"svg": [
"original",
"plain"
],
"font": [
"plain"
]
},
"color": "#3FB6D3",
"aliases": []
},

{
"name": "foundation",
"tags": [
Expand All @@ -939,11 +957,10 @@
"plain-wordmark"
],
"font": [
"plain",
"plain-wordmark"
"plain"
Copy link
Member

@amacado amacado Oct 24, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"plain"
"plain",
"plain-wordmark"

Why you suggest to remove plain-wordmark? We have this icon: https://github.com/devicons/devicon/tree/develop/icons/foundation

]
},
"color": "#008cba",
"color": "#3FB6D3",
"aliases": []
},
{
Expand Down