Skip to content

Only build script will need token API #692

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Thomas-Boi merged 1 commit into from
Jun 24, 2021
Merged

Only build script will need token API #692

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions .github/scripts/build_assets/arg_getters.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,13 +33,13 @@ def get_selenium_runner_args(peek_mode=False):
help="The download destination of the Icomoon files",
action=PathResolverAction)

parser.add_argument("token",
help="The GitHub token to access the GitHub REST API.",
type=str)

if peek_mode:
parser.add_argument("--pr_title",
help="The title of the PR that we are peeking at")
else:
parser.add_argument("token",
help="The GitHub token to access the GitHub REST API.",
type=str)

return parser.parse_args()

Expand Down
2 changes: 1 addition & 1 deletion .github/scripts/icomoon_peek.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
def main():
runner = None
try:
args = arg_getters.get_selenium_runner_args(True)
args = arg_getters.get_selenium_runner_args(peek_mode=True)
new_icons = filehandler.get_json_file_content(args.devicon_json_path)

# get only the icon object that has the name matching the pr title
Expand Down