-
Notifications
You must be signed in to change notification settings - Fork 2.4k
Create a general pull_request_template.md #703
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
f105271
Create a general pull_request_template.md
Thomas-Boi e3f38d3
Apply suggestions from code review
Thomas-Boi af1b3b5
Add line about base of PR in pr template
Thomas-Boi 3876df7
Merge branch 'develop' into thomas/prTemplateFix
Panquesito7 1fb7783
Merge branch 'develop' into thomas/prTemplateFix
Thomas-Boi 58efdd9
Merge branch 'develop' into thomas/prTemplateFix
Panquesito7 fd23677
Merge branch 'develop' into thomas/prTemplateFix
Thomas-Boi 602e47f
Update PR and Issue templates
Thomas-Boi 7c86608
Update .github/drafts/PULL_REQUEST_TEMPLATE/new_icon.md
Thomas-Boi 31c3d72
Update .github/drafts/PULL_REQUEST_TEMPLATE/new_icon.md
Thomas-Boi ec6c641
Update .github/drafts/PULL_REQUEST_TEMPLATE/new_icon.md
Thomas-Boi 18e49c7
Apply suggestions from code review
Panquesito7 c797fdb
Apply suggestions from code review
Panquesito7 51f79c4
Apply suggestions from code review
Panquesito7 73f5fbe
Apply suggestions from code review
Panquesito7 4dffbf7
Apply suggestions from code review
Panquesito7 b906999
Apply suggestions from code review
Panquesito7 7ea77dc
Apply suggestions from code review
Panquesito7 41f857f
Apply suggestions from code review
Panquesito7 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,24 @@ | ||
| --- | ||
| name: New Feature | ||
| about: Add a new feature to the repository. | ||
| title: 'New Feature: [NAME]' | ||
| labels: 'enhancement' | ||
| assignees: '' | ||
|
|
||
| --- | ||
| <!-- If you are adding a new icon, follow the steps listed here, and delete the **New Icon** section above. --> | ||
|
|
||
| ## Double check these details before you open a PR** | ||
|
|
||
| <!-- Tick the checkboxes to ensure you've done everything correctly --> | ||
| - [] PR does not match another non-stale PR currently opened | ||
| - [] PR name matches the format *New Feature: brief description of feature* | ||
|
|
||
|
|
||
| ## This PR adds/fixes... | ||
|
|
||
| <!-- List your features here and the benefits they bring. --> | ||
|
|
||
| ## Notes | ||
|
|
||
| <!-- List anything note-worthy here (potential issues, this needs to be merged to `master` before working, etc.). --> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,23 @@ | ||
| --- | ||
| name: New Icon | ||
| about: Add a new icon to the repository. | ||
| title: 'new icon: [NAME] (versions)' | ||
| labels: 'feature:icon' | ||
| assignees: '' | ||
|
|
||
| --- | ||
| <!-- If you are adding a new icon, follow the steps listed here, and delete the **New Feature** section below. --> | ||
| ## Double check these details before you open a PR | ||
|
|
||
| <!-- Tick the checkboxes to ensure you've done everything correctly --> | ||
| - [] PR does not match another non-stale PR currently opened | ||
| - [] PR name matches the format *new icon: <i>Icon name</i> (<i>versions separated by comma</i>)*. More details [here](https://github.com/devicons/devicon/blob/develop/CONTRIBUTING.md#overview) | ||
| - [] PR's base is the `develop` branch. | ||
| - [] Your icons are inside a folder as seen [here](https://github.com/devicons/devicon/blob/develop/CONTRIBUTING.md#organizational-guidelines) | ||
| - [] SVG matches the standards laid out [here](https://github.com/devicons/devicon/blob/develop/CONTRIBUTING.md#svgStandards) | ||
| - [] A new object is added in the `devicon.json` file as seen [here](https://github.com/devicons/devicon/blob/develop/CONTRIBUTING.md#-updating-the-deviconjson-) | ||
|
|
||
| <!-- Refer to the [contributing](https://github.com/devicons/devicon/blob/develop/CONTRIBUTING.md#contributing-to-devicon) guidelines for more details. --> | ||
|
|
||
| ## Link to prove your SVG is correct and up-to-date. | ||
| <!-- Link to an official page/wiki goes here. Anything that proves your SVGs are the correct ones. --> | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,45 @@ | ||
| --- | ||
| name: Pull Request Template | ||
| about: Add a new icon or feature to the repo. | ||
| title: 'New Icon/Feature: [NAME]' | ||
| assignees: '' | ||
|
|
||
| --- | ||
| # New Icon Section | ||
|
|
||
| <!-- If you are adding a new icon, follow the steps listed here, and delete the **New Feature** section below. --> | ||
|
|
||
| ## Double check these details before you open a PR | ||
|
|
||
| <!-- Tick the checkboxes to ensure you've done everything correctly --> | ||
| - [] PR does not match another non-stale PR currently opened | ||
| - [] PR name matches the format *new icon: <i>Icon name</i> (<i>versions separated by comma</i>)*. More details [here](https://github.com/devicons/devicon/blob/develop/CONTRIBUTING.md#overview) | ||
| - [] PR's base is the `develop` branch. | ||
| - [] Your icons are inside a folder as seen [here](https://github.com/devicons/devicon/blob/develop/CONTRIBUTING.md#organizational-guidelines) | ||
| - [] SVG matches the standards laid out [here](https://github.com/devicons/devicon/blob/develop/CONTRIBUTING.md#svgStandards) | ||
| - [] A new object is added in the `devicon.json` file as seen [here](https://github.com/devicons/devicon/blob/develop/CONTRIBUTING.md#-updating-the-deviconjson-) | ||
|
|
||
| <!-- Refer to the [contributing](https://github.com/devicons/devicon/blob/develop/CONTRIBUTING.md#contributing-to-devicon) guidelines for more details. --> | ||
|
|
||
Panquesito7 marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| ## Link to prove your SVG is correct and up-to-date. | ||
| <!-- Link to an official page/wiki goes here. Anything that proves your SVGs are the correct ones. --> | ||
|
|
||
| --- | ||
| # New Feature Section | ||
|
|
||
| <!-- If you are adding a new icon, follow the steps listed here, and delete the **New Icon** section above. --> | ||
|
|
||
| ## Double check these details before you open a PR** | ||
|
|
||
| <!-- Tick the checkboxes to ensure you've done everything correctly --> | ||
| - [] PR does not match another non-stale PR currently opened | ||
| - [] PR name matches the format *New Feature: brief description of feature* | ||
|
|
||
|
|
||
| ## This PR adds/fixes... | ||
|
|
||
| <!-- List your features here and the benefits they bring. --> | ||
|
|
||
| ## Notes | ||
|
|
||
| <!-- List anything note-worthy here (potential issues, this needs to be merged to `master` before working, etc.). --> | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.