-
Notifications
You must be signed in to change notification settings - Fork 2.4k
Upgrade PR and Issue Templates #986
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
855e474
Update issue templates
Thomas-Boi b33c719
Add pr templates
Thomas-Boi 48a904a
Update templates
Thomas-Boi 77a9551
Update pr templates
Thomas-Boi f426415
Update default pr template
Thomas-Boi 7ea09b8
Merge branch 'develop' into thomas/feature/templatesUpgrade
Panquesito7 92fa962
Clarify pr closing statement
Thomas-Boi 123369e
Merge branch 'thomas/feature/templatesUpgrade' of https://github.com/…
Thomas-Boi 4ea7b69
Merge branch 'develop' into thomas/feature/templatesUpgrade
Panquesito7 add62d7
Apply suggestions from code review
Thomas-Boi 6c8e9c8
Update .github/PULL_REQUEST_TEMPLATE/new_feature.md
Thomas-Boi 901fb50
Merge branch 'develop' into thomas/feature/templatesUpgrade
Thomas-Boi File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,13 @@ | ||
| ## Double check these details before you open a PR | ||
|
|
||
| <!-- Tick the checkboxes to ensure you've done everything correctly --> | ||
| - [ ] PR does not match another non-stale PR currently opened | ||
|
|
||
| ## Features | ||
| <!-- List your features here and the benefits they bring. Include images/codes as appropriate --> | ||
|
|
||
| **This PR closes NONE** | ||
| <!-- List issues that this PR would close above. Ex: This PR closes #1, #2, #3. --> | ||
|
|
||
| ## Notes | ||
| <!-- List anything note-worthy here (potential issues, this needs to be merged to `master` before working, etc.). --> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,38 +1,5 @@ | ||
| # **New icon section** | ||
| ### Adding a New Icon? | ||
| - Add `?quick_pull=1&template=new_icon.md` to the end of your current URL and press `Enter` | ||
|
|
||
| <!-- If you are adding a new icon, follow the steps listed here, and delete the **New feature** section below. --> | ||
|
|
||
| ## Double check these details before you open a PR | ||
|
|
||
| <!-- Tick the checkboxes to ensure you've done everything correctly --> | ||
| - [ ] PR does not match another non-stale PR currently opened | ||
| - [ ] PR name matches the format *new icon: <i>Icon name</i> (<i>versions separated by comma</i>)*. More details [here](https://github.com/devicons/devicon/blob/develop/CONTRIBUTING.md#overview) | ||
| - [ ] The PR's base is the `develop` branch. | ||
| - [ ] Your icons are inside a folder as seen [here](https://github.com/devicons/devicon/blob/develop/CONTRIBUTING.md#organizational-guidelines) | ||
| - [ ] SVG matches the standards laid out [here](https://github.com/devicons/devicon/blob/develop/CONTRIBUTING.md#svgStandards) | ||
| - [ ] A new object is added in the `devicon.json` file as seen [here](https://github.com/devicons/devicon/blob/develop/CONTRIBUTING.md#-updating-the-deviconjson-) | ||
|
|
||
| <!-- Refer to the contributing guidelines for more details https://github.com/devicons/devicon/blob/develop/CONTRIBUTING.md#contributing-to-devicon --> | ||
|
|
||
| ## Link to prove your SVG is correct and up-to-date | ||
|
|
||
| <!-- Link to an official page/wiki goes here. Anything that proves your SVGs are the correct ones. --> | ||
|
|
||
| --- | ||
| # **New feature section** | ||
|
|
||
| <!-- If you are adding a new feature, follow the steps listed here, and delete the **New icon** section above. --> | ||
|
|
||
| ## Double check these details before you open a PR | ||
|
|
||
| <!-- Tick the checkboxes to ensure you've done everything correctly --> | ||
| - [ ] PR does not match another non-stale PR currently opened | ||
| - [ ] PR name matches the format *New Feature: a brief description of feature* | ||
|
|
||
| ## This PR adds/fixes | ||
|
|
||
| <!-- List your features here and the benefits they bring. --> | ||
|
|
||
| ## Notes | ||
|
|
||
| <!-- List anything note-worthy here (potential issues, this needs to be merged to `develop` before working, etc.). --> | ||
| ### Adding a New Feature or fixing a bug? | ||
| - Add `?quick_pull=1&template=new_feature.md` to the end of your current URL and press `Enter`. |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.