ogc: do not create a new mouse cursor at every frame #41
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The system default cursor is not supposed to change, so we can create it just once (when the mouse gets initialized). In the polling callback we then just need to hide or show it. The logic of showing is not changed: if the application has set a specific cursor, then it's in full control of its visibility; but if it's using the default cursor, then we show the cursor only if at least one wiimote is pointed at the screen.
WinterMute
pushed a commit
that referenced
this pull request
Jan 20, 2024
WinterMute
pushed a commit
that referenced
this pull request
Oct 27, 2024
The system default cursor is not supposed to change, so we can create it just once (when the mouse gets initialized). In the polling callback we then just need to hide or show it. The logic of showing is not changed: if the application has set a specific cursor, then it's in full control of its visibility; but if it's using the default cursor, then we show the cursor only if at least one wiimote is pointed at the screen.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The system default cursor is not supposed to change, so we can create it just once (when the mouse gets initialized). In the polling callback we then just need to hide or show it.
The logic of showing is not changed: if the application has set a specific cursor, then it's in full control of its visibility; but if it's using the default cursor, then we show the cursor only if at least one wiimote is pointed at the screen.