ogc: add USB keyboard support #68
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SDL_SendKeyboardText checks for these anyway
mardy
requested changes
Apr 12, 2024
Collaborator
mardy
left a comment
mardy
left a comment
There was a problem hiding this comment.
Thanks, looks great! Just minor nitpicks.
Collaborator
|
Thanks, LGTM. I would have squashed the changes from the last commit with the respective commits which introduced the changes, in order not to create "noise" in the git history, but the code looks good to me. I'll leave the final word to @WinterMute :-) |
mardy
approved these changes
Apr 13, 2024
Member
|
Good job, thanks for the PR. I've merged this & rebuilt our sdl2 packages so it should be usable with stock now. |
WinterMute
pushed a commit
that referenced
this pull request
Oct 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a new file,
SDL_ogckeyboard.cthat handles keyboard events using libwiikeyboard. It also converts the 16-bit Unicode symbol from libwiikeyboard into a UTF-8 array if text input is enabled.Right now some key inputs (e.g. Home, Arrow Keys, etc.) give text inputs even when we don't want themTurns out libwiikeyboard stores these in the private area (0xE000-0xFF8F), so they're easy enough to filter out.