Misc fixes: lists, stencil, EFB issues #76
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use a similar logic as for the color attribute: add it to the display lists only if it was issued within a glBegin()/glEnd() pair.
As a matter of fact, this does not seem to make any difference, but it seems more correct nevertheless.
The hardcoded one was a copy-paste mistake.
GX_GetTexObjAll() returns the address to the physical pixel buffer, exactly like GX_GetTexObjData() does. We need to convert it to a virtual address. This mistake was causing no issues in Dolphin, but on the hardware it was causing cache coherency issues.
The tex_maps is a pointer, and we want to print its contents.
This fixes wrong shading in the dinoshade sample[1]: the program draws a dinosaur using call lists in which the normal coordinates are not given; instead, normals are set using glNormal() at the time when the list is executed, which is something we did not support before, since all our vertex data was encoded in the GX call lists. Now, if the color or normal is not given, encode them as indexed data, which will point to the current color and normal at the time when the list is executed. [1]: https://www.opengl.org/archives/resources/code/samples/glut_examples/examples/dinoshade.c
This command is now not issued anymore.
Support glPolygonMode() by patching the GX_Begin() operand in the stored call lists.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The biggest commits are about changing the handling of glDrawElements() and glDrawArrays() inside glCallList(): instead of merging different lists together, now each command is played back individually (allowing the stencil buffer to update in between). Also, fix the handling of vertex normals when they were not specified at list creation time (we must use the current normal vector in that case).
A couple of commits are about implementing glPolygonMode() (which would have been impossible to implement in call lists if we hadn't changed the list implementation).
Other commits are smallers and don't need additional explanation beside what is in their commit message.