Textured points #86
Merged
Textured points #86
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- The GX_SetPointSize() accepts an unsigned byte, so clamp the size to 255. - Remove the multiplication by 16, it's not clear why that was there in the first place. - Set the lower right corner of the point to have texture coordinates (1, 1): this allows drwaing textures on points.
Even if the client state has texture coordinates disabled, they might still be generated.
These variables will be used in the next commits.
If the GL_COORD_REPLACE flag is set, then instead of the texture coordinates found on the vertex, we should use a hardcoded (0, 0) coordinate for the top left corner, and (1, 1) for the bottom right. We do this by replacing the vertex array with the PointSpritesTexReader class, whose reader method always returns (0, 0). We also need to modify a few other places so that the array classes know what is the primitive being drawn, because this swap must only be applied when rendering points.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A few commits to enable sprite particles in Neverball.