Call list and state improvements #90
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GX matrices are 3x4, and the old code was overflowing: wee need to skip the fourth row of the matrix. Fixes one issue from devkitPro#87
It was using the Mtx44 matrix, which is row-major, whereas glMultMatrix expects a column-major matrix.
This causes FIFO errors, since we told GX that we are sending two coordinates, but effectively send three. So we need to ensure that we never send more than two texture coordinates.
Add an "as_int" member that allows comparing the structure as a whole.
Move the setup_fog() sunction out of the _ogx_setup_render_stages() function and into _ogx_apply_state(), since by render stages we mean all waht is related with the TEV stages. Add a dirty bit to signal when the fogging configuration has changed and needs to be setup again.
Add a dirty flag to track whether the TEV stages must be rebuilt. The replaces the dirty_lighting, dirty_clip_planes, dirty_stencil and the (de facto unused) dirty_material flags, because all these factors ultimately require the TEV to be rebuilt. This is not super-precide, and we err on the side of rendering safety, but it still brings a huge speed up in the crack-attack game, which uses call lists with several draw commands in each (so the state is guaranteed to be clean between one command and the next).
This is not a terribly heavy operation, but since it's not hard to optimize it out, let's do it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
crack-attack performance went down a lot when we introduced support for clipping, since that's an extra TEV stage and it involves some matrix multiplications. On the other hand, we don't have to setup the TEV stages if no parameters affecting it have been changed.
This MR fixes a couple of regressions, cleans up the fogging setup and adds a "dirty bit" to decide when the TEV stages must be rebuilt.
To be merged after #88