Ensure dotnet build works too #141
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kzu
force-pushed
the
dev/restoreextensions
branch
2 times, most recently
from
ef64c28 to
4b8705d
Compare
Both `ImportProjectExtensionProps` and `ImportProjectExtensionTargets` must be set to true, and we now use `MSBuildProjectExtensionsPath` to leverage the standard way of importing these targets. See dotnet/msbuild#9512 Fixes #139
kzu
force-pushed
the
dev/restoreextensions
branch
from
4b8705d to
f83436e
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Both
ImportProjectExtensionPropsandImportProjectExtensionTargetsmust be set to true, and we now useMSBuildProjectExtensionsPathto leverage the standard way of importing these targets.See dotnet/msbuild#9512
Fixes #139