#637: Option to disable updates #765
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KianRolf
added
enhancement
…into test/no-updates
…into test/no-updates
Collaborator
Pull Request Test Coverage Report for Build 11968342240Details
💛 - Coveralls |
jan-vcapgemini
requested changes
Nov 18, 2024
Contributor
jan-vcapgemini
left a comment
jan-vcapgemini
left a comment
There was a problem hiding this comment.
Thanks for adding an option to disable the updates. I've added some CRs, please resolve.
cli/src/main/java/com/devonfw/tools/ide/commandlet/ContextCommandlet.java
Outdated
Show resolved
Hide resolved
cli/src/test/java/com/devonfw/tools/ide/commandlet/HelpCommandletTest.java
Outdated
Show resolved
Hide resolved
…letTest.java Co-authored-by: jan-vcapgemini <59438728+jan-vcapgemini@users.noreply.github.com>
…andlet.java Co-authored-by: jan-vcapgemini <59438728+jan-vcapgemini@users.noreply.github.com>
Co-authored-by: jan-vcapgemini <59438728+jan-vcapgemini@users.noreply.github.com>
Co-authored-by: jan-vcapgemini <59438728+jan-vcapgemini@users.noreply.github.com>
Co-authored-by: jan-vcapgemini <59438728+jan-vcapgemini@users.noreply.github.com>
jan-vcapgemini
approved these changes
Nov 18, 2024
Contributor
jan-vcapgemini
left a comment
jan-vcapgemini
left a comment
There was a problem hiding this comment.
Thanks. Ready for review.
hohwille
approved these changes
Nov 20, 2024
Member
hohwille
left a comment
hohwille
left a comment
There was a problem hiding this comment.
@KianRolf thanks for your PR. You implemented this feature nicely but stepped into a pitfall I caused by accident with a comment. 👍
I also suggested and explained not to add -s short option and by doing so, you can also revert changes you needed to apply to completion tests.
When the review comments are resolved, we can merge.
cli/src/main/java/com/devonfw/tools/ide/commandlet/ContextCommandlet.java
Outdated
Show resolved
Hide resolved
cli/src/test/java/com/devonfw/tools/ide/commandlet/HelpCommandletTest.java
Outdated
Show resolved
Hide resolved
cli/src/test/java/com/devonfw/tools/ide/completion/CompleteTest.java
Outdated
Show resolved
Hide resolved
cli/src/test/java/com/devonfw/tools/ide/completion/CompleteTest.java
Outdated
Show resolved
Hide resolved
cli/src/test/java/com/devonfw/tools/ide/completion/CompleteTest.java
Outdated
Show resolved
Hide resolved
cli/src/main/java/com/devonfw/tools/ide/tool/LocalToolCommandlet.java
Outdated
Show resolved
Hide resolved
…andlet.java Co-authored-by: Jörg Hohwiller <hohwille@users.noreply.github.com>
…letTest.java Co-authored-by: Jörg Hohwiller <hohwille@users.noreply.github.com>
…t.java Co-authored-by: Jörg Hohwiller <hohwille@users.noreply.github.com>
…t.java Co-authored-by: Jörg Hohwiller <hohwille@users.noreply.github.com>
…t.java Co-authored-by: Jörg Hohwiller <hohwille@users.noreply.github.com>
hohwille
reviewed
Nov 22, 2024
cli/src/main/java/com/devonfw/tools/ide/tool/LocalToolCommandlet.java
Outdated
Show resolved
Hide resolved
…et.java Co-authored-by: Jörg Hohwiller <hohwille@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #637
Allows the user to call tools with
--skip-updates, which skips updates for the tool if the configured version and the installed version match.