Skip to content

Conversation

@glyad
Copy link
Member

@glyad glyad commented Mar 6, 2023

PULL REQUEST

Descriptions

  • Add the router
  • Make the nav menu dynamically generated from the navigation model
  • Highlight the active route in nav menu visually

Linked Issue(s)

Resolves #7

Type of change

  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Test Configuration:

  • Firmware version:
  • Hardware:
  • Toolchain:
  • SDK:

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@glyad glyad added the enhancement Enhancement of the code, not introducing new features. label Mar 6, 2023
@glyad glyad added this to the milestone: #1 milestone Mar 6, 2023
@glyad glyad self-assigned this Mar 6, 2023
@glyad glyad linked an issue Mar 14, 2023 that may be closed by this pull request
4 tasks
@glyad glyad marked this pull request as ready for review March 14, 2023 12:50
@glyad glyad added priority-high After critical issues are fixed, these should be dealt with before any further issues. new-feature New features or options. labels Mar 14, 2023
@glyad glyad merged commit b7a78b2 into develop Mar 14, 2023
@glyad glyad deleted the feature/implement-the-router-and-left-side-nav branch March 14, 2023 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement Enhancement of the code, not introducing new features. new-feature New features or options. priority-high After critical issues are fixed, these should be dealt with before any further issues.

Projects

Status: In Progress 🚧

Development

Successfully merging this pull request may close these issues.

🚀 Implement the router and left-side nav

2 participants