OMPI: Notified-OSC-SM Operations #8
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello! The Git Commit Checker CI bot found a few problems with this PR: 58c4c26: Notified osc SM
Please fix these problems and, if necessary, force-push new commits back up to the PR branch. Thanks! |
This commit adds notification support to the OSC SM component by implementing the put_with_notify, get_with_notify, rput_with_notify, and rget_with_notify functions. These functions perform the same operations as their non-notify counterparts but also increment notification counters after the data transfer completes. The changes include: - Added function pointer types for notify variants in osc.h - Added function prototypes in osc_sm.h - Implemented the notify functions in osc_sm_comm.c - Updated the module template to register the new functions - Removed TODO comments that have been addressed Signed-off-by: Joseph Antony <jajoseph.antony18@gmail.com>
joe-explr
force-pushed
the
notified-rma-sm
branch
from
58c4c26 to
0f9a9ac
Compare
devreal
requested changes
Nov 4, 2025
Owner
devreal
left a comment
devreal
left a comment
There was a problem hiding this comment.
Looks good, please fix the indentation and add the sign-off
ompi/mca/osc/sm/osc_sm_comm.c
Outdated
| int notify, | ||
| struct ompi_win_t *win) | ||
| { | ||
| int ret; |
Owner
There was a problem hiding this comment.
Nitpick: indentation is off in this function
ompi/mca/osc/sm/osc_sm_comm.c
Outdated
| origin_addr, origin_count, origin_dt); | ||
| // TODO: do the same for put_with_notify | ||
| if (OMPI_SUCCESS != ret) { | ||
| return ret; |
ompi/mca/osc/sm/osc_sm_comm.c
Outdated
|
|
||
| return OMPI_SUCCESS;; | ||
| } | ||
| } |
Owner
There was a problem hiding this comment.
Please revert the change removing the newline at the end
Signed-off-by: Joseph Antony <jajoseph.antony18@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add notification support for put/get operations:
Adds notification support to the OSC SM component by
implementing the put_with_notify, get_with_notify, rput_with_notify,
and rget_with_notify functions. These functions perform the same
operations as their non-notify counterparts but also increment
notification counters after the data transfer completes.
The changes include: