partial and helper resolvers

[mitsh]

Hello,

Thanks for your huge contribution after LightnCandy. I've just switched from LightnCandy to php-handlebars(which is good name).

I've been using LnC with partialresolver and helperresolver options. Do you have any plan to support resolvers?

Cheers!

[theodorejb]

Hi @mitsh, I'm glad you found the library useful!

My goal is to try to match the functionality and API of Handlebars.js as closely as possible. Could you share more about your use case for resolvers? Is it not possible to use regular custom helpers and dynamic partials?

[mitsh]

Hi @theodorejb,

My goal is to try to match the functionality and API of Handlebars.js as closely as possible.

I think your approach is good. If it aligns to Handlebars.js we can use same logic in JS and PHP.

Could you share more about your use case for resolvers?

Those resolvers are just Closures that use Context and partial names to manipulate partial in runtime. Here is the example in LightnCandy: https://zordius.github.io/HandlebarsCookbook/9902-lcop-partialresolver.html.

Is it not possible to use regular custom helpers and dynamic partials?

I haven't tried dynamic partials, let me try.

[mitsh]

Hello @theodorejb!

I've made a fork from your repos and added that what I want. Please feel free to review my change and let me know if you accept a PR.

https://github.com/mitsh/php-handlebars

You can find changes at latest commit.

[theodorejb]

Hi @mitsh, can you share more about your use case for partial and helper resolvers? I'm open to accepting a PR, but it needs to include tests to verify that the functions work as expected.

[mitsh]

Hi @theodorejb,

I use partial and helpers resolverss as it is in Lightncandy. And I tried to add same functionalty into your project.

https://zordius.github.io/HandlebarsCookbook/9901-lcop-helperresolver.html
https://zordius.github.io/HandlebarsCookbook/9902-lcop-partialresolver.html

here is my approach. it's not long, please take a look and share your opinion. I bet you can do it better and in proper way.
master...mitsh:php-handlebars:master

[theodorejb]

Implemented in v0.9.7.

[mitsh]

@theodorejb thank you!

[theodorejb]

Note that in PHP Handlebars 1.0, the helperResolver compile option has been replaced with support for the helperMissing and blockHelperMissing custom helper hooks which Handlebars.js also uses. See the release notes for details: https://github.com/devtheorem/php-handlebars/releases/tag/v1.0.0