Skip to content
This repository was archived by the owner on Feb 2, 2021. It is now read-only.

Support Swift 5.0 and RxSwift 5.0#12

Open
tokijh wants to merge 5 commits intodevxoul:masterfrom
tokijh:master
Open

Support Swift 5.0 and RxSwift 5.0#12
tokijh wants to merge 5 commits intodevxoul:masterfrom
tokijh:master

Conversation

@tokijh
Copy link

@tokijh tokijh commented May 8, 2019

Deprecated

  • RxExpect.input(Variable) is deprecated because Variable is deprecated on RxSwift

Noti

I didn't test Carthage and CocoaPods installation. You should test it...
I also set the version of RxExpect to 1.3.0. Please check and fix or comment, if you want

@codecov-io
Copy link

codecov-io commented May 8, 2019

Codecov Report

Merging #12 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #12   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           4      5    +1     
  Lines          78     78           
=====================================
  Hits           78     78
Impacted Files Coverage Δ
Sources/RxExpect/AnyTestTime.swift 100% <100%> (ø) ⬆️
Sources/RxExpect/Assertion.swift 100% <100%> (ø) ⬆️
Sources/RxExpect/Deprecated.swift 100% <100%> (ø)
Sources/RxExpect/RxExpect.swift 100% <100%> (ø) ⬆️
Sources/RxExpect/Utility.swift 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aa82dc5...cb0da8a. Read the comment docs.

@tokijh
Copy link
Author

tokijh commented May 24, 2019

@devxoul can you check this?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants