You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Expands workload policy fields and documentation while syncing proto definitions for getClusterIdByName. Resolves local compilation issues by including missing profiling protocol buffers.
✅ 2 resolved✅ Bug: Missing profiling.proto breaks local proto compilation
📄 internal/proto/api/v1/recommendation.proto:15📄 internal/proto/api/v1/recommendation.proto:3466-3474📄 internal/proto/api/v1/recommendation.proto:3480-3485
recommendation.proto imports api/v1/profiling.proto (line 15), and the new messages WorkloadProfileManifest (line 3466) and BatchWorkloadProfiles (line 3480) reference types from it (ProfileWindow, ProfileKey, WorkloadProfileSnapshot). However, profiling.proto does not exist anywhere in the repository. While the pre-generated .pb.go files appear to contain these types (suggesting they were generated externally), anyone running protoc locally against these .proto sources will get an import-not-found error.
If protos are synced from an external registry, the sync should include profiling.proto. If it's intentionally omitted, the new messages that depend on it should not reference those types until the file is available.
✅ Bug: Missing profiling_grpc.pb.go and profiling.connect.go in Makefile sync
📄 Makefile:27-29 profiling.proto defines service ProfilingService with an RPC, which means protoc will generate both profiling_grpc.pb.go and profiling.connect.go. Neither file is listed in the Makefile sync variables, so make proto will not copy them into the target directories. This follows the same pattern as cluster.proto, which has cluster_grpc.pb.go in GEN_PB_FILES and cluster.connect.go in GEN_CONNECT_FILES.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
add proto sync and docs in more detail
Summary by Gitar
adjustReqEvenIfNotSet,limitsRemovalEnabled, andenablePmaxProtectionacross all language SDKs.limitsRemovalEnabledforVerticalScalingapplies only to the CPU axis, with memory limits removal unsupported.This will update automatically on new commits.