Skip to content

Feat/workload policy pmax vpa fields docs#23

Merged
Rupam-It merged 8 commits into
mainfrom
feat/workload-policy-pmax-vpa-fields-docs
May 6, 2026
Merged

Feat/workload policy pmax vpa fields docs#23
Rupam-It merged 8 commits into
mainfrom
feat/workload-policy-pmax-vpa-fields-docs

Conversation

@Rupam-It
Copy link
Copy Markdown
Collaborator

@Rupam-It Rupam-It commented Apr 30, 2026

add proto sync and docs in more detail


Summary by Gitar

  • Documentation Updates:
    • Corrected default value descriptions for adjustReqEvenIfNotSet, limitsRemovalEnabled, and enablePmaxProtection across all language SDKs.
    • Clarified that limitsRemovalEnabled for VerticalScaling applies only to the CPU axis, with memory limits removal unsupported.

This will update automatically on new commits.

Comment thread internal/proto/api/v1/recommendation.proto
Comment thread Makefile Outdated
@gitar-bot
Copy link
Copy Markdown

gitar-bot Bot commented May 5, 2026

Code Review ✅ Approved 2 resolved / 2 findings

Expands workload policy fields and documentation while syncing proto definitions for getClusterIdByName. Resolves local compilation issues by including missing profiling protocol buffers.

✅ 2 resolved
Bug: Missing profiling.proto breaks local proto compilation

📄 internal/proto/api/v1/recommendation.proto:15 📄 internal/proto/api/v1/recommendation.proto:3466-3474 📄 internal/proto/api/v1/recommendation.proto:3480-3485
recommendation.proto imports api/v1/profiling.proto (line 15), and the new messages WorkloadProfileManifest (line 3466) and BatchWorkloadProfiles (line 3480) reference types from it (ProfileWindow, ProfileKey, WorkloadProfileSnapshot). However, profiling.proto does not exist anywhere in the repository. While the pre-generated .pb.go files appear to contain these types (suggesting they were generated externally), anyone running protoc locally against these .proto sources will get an import-not-found error.

If protos are synced from an external registry, the sync should include profiling.proto. If it's intentionally omitted, the new messages that depend on it should not reference those types until the file is available.

Bug: Missing profiling_grpc.pb.go and profiling.connect.go in Makefile sync

📄 Makefile:27-29
profiling.proto defines service ProfilingService with an RPC, which means protoc will generate both profiling_grpc.pb.go and profiling.connect.go. Neither file is listed in the Makefile sync variables, so make proto will not copy them into the target directories. This follows the same pattern as cluster.proto, which has cluster_grpc.pb.go in GEN_PB_FILES and cluster.connect.go in GEN_CONNECT_FILES.

Was this helpful? React with 👍 / 👎 | Gitar

@Rupam-It Rupam-It merged commit 418ac41 into main May 6, 2026
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants