PC-902 Netmon heatlcheck + endpoints#303
Merged
Merged
Conversation
added 2 commits
February 26, 2026 10:32
Move HealthManager creation and health server startup to before ctrl.NewManager() so K8s probes are answered immediately, preventing connection refused and 503 errors during slow initialization.
|
Important Upgrade your plan to unlock code review, CI analysis, custom rules, and more. |
Ignas
approved these changes
Feb 26, 2026
Parthiba-Hazra
pushed a commit
that referenced
this pull request
May 5, 2026
* fix: start health server before manager init to prevent 503 on upgrades Move HealthManager creation and health server startup to before ctrl.NewManager() so K8s probes are answered immediately, preventing connection refused and 503 errors during slow initialization. * Netmon healthcheck * Resync zxporter main with main branch * Suppress golint-ci * Lint fix
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[Add health checks to zxporter-netmon]
📚 Description of Changes
/healthzreturns a 503 status when a fatal component fails./readyzindicates the readiness of configuration, collector, and transport.Develop a goroutine in zxporter that builds a health report from HealthManager every 60 seconds and sends it to Dakr using the ReportHealth RPC. Handle RPC failures gracefully and log warnings as needed. (follow same approach through we use in zxporter)
What Changed:
(Describe the modifications, additions, or removals.)
Why This Change:
(Explain the problem this PR addresses or the improvement it provides.)
Affected Components:
(Which component does this change affect? - put x for all components)
Compose
K8s
Other (please specify)
❓ Motivation and Context
Why is this change required? What problem does it solve?
Context:
(Provide background information or link to related discussions/issues.)
Relevant Tasks/Issues:
https://devinfra.atlassian.net/browse/PC-909
https://devinfra.atlassian.net/browse/PC-910
https://devinfra.atlassian.net/browse/PC-911
https://devinfra.atlassian.net/browse/PC-912
🔍 Types of Changes
Indicate which type of changes your code introduces (check all that apply):
🔬 QA / Verification Steps
Describe the steps a reviewer should take to verify your changes:
make testto verify all tests pass.")make create-kind && make deploy.")✅ Global Checklist
Please check all boxes that apply: