PC-904 dzKarp health monitor#315
Merged
Merged
Conversation
|
Important Upgrade your plan to unlock code review, CI analysis, custom rules, and more. |
kevin-devzero
requested changes
Mar 10, 2026
Contributor
kevin-devzero
left a comment
kevin-devzero
left a comment
There was a problem hiding this comment.
looks better! lets try in preprod
| // isDevZeroImage checks whether the deployment uses a DevZero container image. | ||
| func isDevZeroImage(dep *appsv1.Deployment) bool { | ||
| for _, c := range dep.Spec.Template.Spec.Containers { | ||
| if strings.HasPrefix(c.Image, devzeroImagePrefix) { |
Contributor
There was a problem hiding this comment.
maybe substring instead of prefix
kevin-devzero
approved these changes
Mar 11, 2026
Parthiba-Hazra
pushed a commit
that referenced
this pull request
May 5, 2026
* dzKarp health monitor * Better allocations and error checking for response body * Implement requested changes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[HealthManager for dzKarp]
📚 Description of Changes
Provide an overview of your changes and why they’re needed. Link to any related issues (e.g., "Fixes #123"). If your PR fixes a bug, resolves a feature request, or updates documentation, please explain how.
What Changed:
(Describe the modifications, additions, or removals.)
Why This Change:
(Explain the problem this PR addresses or the improvement it provides.)
Affected Components:
(Which component does this change affect? - put x for all components)
Compose
K8s
Other (please specify)
❓ Motivation and Context
Why is this change required? What problem does it solve?
Context:
(Provide background information or link to related discussions/issues.)
Relevant Tasks/Issues:
https://devinfra.atlassian.net/browse/PC-917
https://devinfra.atlassian.net/browse/PC-918
https://devinfra.atlassian.net/browse/PC-919
https://devinfra.atlassian.net/browse/PC-920
🔍 Types of Changes
Indicate which type of changes your code introduces (check all that apply):
🔬 QA / Verification Steps
Describe the steps a reviewer should take to verify your changes:
make testto verify all tests pass.")make create-kind && make deploy.")✅ Global Checklist
Please check all boxes that apply: