Skip to content

[HPA] broadcast network metrics also for HPA#346

Merged
Parthiba-Hazra merged 3 commits into
mainfrom
ph/hpa
Apr 8, 2026
Merged

[HPA] broadcast network metrics also for HPA#346
Parthiba-Hazra merged 3 commits into
mainfrom
ph/hpa

Conversation

@Parthiba-Hazra
Copy link
Copy Markdown
Collaborator

@Parthiba-Hazra Parthiba-Hazra commented Apr 2, 2026

[Title]

📚 Description of Changes

Provide an overview of your changes and why they’re needed. Link to any related issues (e.g., "Fixes #123"). If your PR fixes a bug, resolves a feature request, or updates documentation, please explain how.

  • What Changed:
    (Describe the modifications, additions, or removals.)

  • Why This Change:
    (Explain the problem this PR addresses or the improvement it provides.)

  • Affected Components:
    (Which component does this change affect? - put x for all components)

  • Compose

  • K8s

  • Other (please specify)

❓ Motivation and Context

Why is this change required? What problem does it solve?

  • Context:
    (Provide background information or link to related discussions/issues.)

  • Relevant Tasks/Issues:
    (e.g., Fixes: #GitHub Issue)

🔍 Types of Changes

Indicate which type of changes your code introduces (check all that apply):

  • BUGFIX: Non-breaking fix for an issue.
  • NEW FEATURE: Non-breaking addition of functionality.
  • BREAKING CHANGE: Fix or feature that causes existing functionality to not work as expected.
  • ENHANCEMENT: Improvement to existing functionality.
  • CHORE: Changes that do not affect production (e.g., documentation, build tooling, CI).

🔬 QA / Verification Steps

Describe the steps a reviewer should take to verify your changes:

  1. (Step one: e.g., "Run make test to verify all tests pass.")
  2. (Step two: e.g., "Deploy to a Kind cluster with make create-kind && make deploy.")
  3. (Additional steps as needed.)

✅ Global Checklist

Please check all boxes that apply:

  • I have read and followed the CONTRIBUTING guidelines.
  • My code follows the code style of this project.
  • I have updated the documentation as needed.
  • I have added tests that cover my changes.
  • All new and existing tests have passed locally.
  • I have run this code in a local environment to verify functionality.
  • I have considered the security implications of this change.

Summary by Gitar

  • Network metrics broadcasting:
    • Added NetworkReceiveBytesPerSec and NetworkTransmitBytesPerSec fields to container metrics broadcast in mpa_server.go

This will update automatically on new commits.

@gitar-bot
Copy link
Copy Markdown

gitar-bot Bot commented Apr 3, 2026

Code Review ✅ Approved

Extends Prometheus metrics collection to include network metrics and CPU throttle metrics for HPA monitoring. No issues found.

Was this helpful? React with 👍 / 👎 | Gitar

@Parthiba-Hazra Parthiba-Hazra merged commit c467c79 into main Apr 8, 2026
26 of 28 checks passed
@Parthiba-Hazra Parthiba-Hazra deleted the ph/hpa branch April 8, 2026 15:55
Parthiba-Hazra added a commit that referenced this pull request May 5, 2026
* broadcast network metrics also

* configure prometheus to collect cpu throttle metrics also
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants