Skip to content

Fix report from karpenter#353

Merged
mutantkeyboard merged 1 commit into
mainfrom
node_health_fix
Apr 15, 2026
Merged

Fix report from karpenter#353
mutantkeyboard merged 1 commit into
mainfrom
node_health_fix

Conversation

@mutantkeyboard
Copy link
Copy Markdown
Contributor

@mutantkeyboard mutantkeyboard commented Apr 15, 2026

[Fix transient report from karpenter]

📚 Description of Changes

We ping karpenter liveness + readiness probes via zxporter, and we'd normaly report status DEGRADED if both of th conditions weren't met, but we forgot to encounter the transient data - deployment, rollout, TCP connection down, etc.

  • What Changed:
    Minor change in logic to remove false positives for DEGRADED

  • Why This Change:

  • Affected Components:
    (Which component does this change affect? - put x for all components)

  • Compose

  • K8s

  • Other (please specify)

❓ Motivation and Context

Why is this change required? What problem does it solve?

  • Context:
    (Provide background information or link to related discussions/issues.)

  • Relevant Tasks/Issues:
    (e.g., Fixes: #GitHub Issue)

🔍 Types of Changes

Indicate which type of changes your code introduces (check all that apply):

  • BUGFIX: Non-breaking fix for an issue.
  • NEW FEATURE: Non-breaking addition of functionality.
  • BREAKING CHANGE: Fix or feature that causes existing functionality to not work as expected.
  • ENHANCEMENT: Improvement to existing functionality.
  • CHORE: Changes that do not affect production (e.g., documentation, build tooling, CI).

🔬 QA / Verification Steps

Describe the steps a reviewer should take to verify your changes:

  1. (Step one: e.g., "Run make test to verify all tests pass.")
  2. (Step two: e.g., "Deploy to a Kind cluster with make create-kind && make deploy.")
  3. (Additional steps as needed.)

✅ Global Checklist

Please check all boxes that apply:

  • I have read and followed the CONTRIBUTING guidelines.
  • My code follows the code style of this project.
  • I have updated the documentation as needed.
  • I have added tests that cover my changes.
  • All new and existing tests have passed locally.
  • I have run this code in a local environment to verify functionality.
  • I have considered the security implications of this change.

@gitar-bot
Copy link
Copy Markdown

gitar-bot Bot commented Apr 15, 2026

Code Review ✅ Approved

Updates the Karpenter configuration to resolve the reported incident. No issues found.

Was this helpful? React with 👍 / 👎 | Gitar

@mutantkeyboard mutantkeyboard enabled auto-merge (squash) April 15, 2026 15:49
@mutantkeyboard mutantkeyboard merged commit adf3ce0 into main Apr 15, 2026
25 of 26 checks passed
@mutantkeyboard mutantkeyboard deleted the node_health_fix branch April 15, 2026 15:56
Parthiba-Hazra added a commit that referenced this pull request May 5, 2026
- Fix report form operator to include real data and not just aprehended status
Parthiba-Hazra added a commit that referenced this pull request May 5, 2026
- Fix report form operator to include real data and not just aprehended status
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants