Add build step to CI workflow#100
Merged
dex3r merged 2 commits intofeature/metehod_templatefrom Apr 2, 2026
Merged
Conversation
…fully Agent-Logs-Url: https://github.com/dex3r/EasySourceGenerators/sessions/1f59a137-8797-47f2-a6a3-b8297d162636 Co-authored-by: dex3r <3155725+dex3r@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Add step to ci.yml to ensure successful solution build
Add build step to CI workflow
Apr 2, 2026
|
Contributor
There was a problem hiding this comment.
Pull request overview
Adds an explicit build step to the CI pipeline so the full solution is compiled before tests run, rather than relying on test-driven builds.
Changes:
- Insert
dotnet build EasySourceGenerators.sln --no-restorebetween restore and test steps. - Switch
dotnet testfrom--no-restoreto--no-buildto avoid rebuilding during test execution.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
|
||
| - name: Test | ||
| run: dotnet test EasySourceGenerators.sln --no-restore --verbosity normal --collect:"XPlat Code Coverage" --logger "trx;LogFilePrefix=test-results" --results-directory ./coverage | ||
| run: dotnet test EasySourceGenerators.sln --no-build --verbosity normal --collect:"XPlat Code Coverage" --logger "trx;LogFilePrefix=test-results" --results-directory ./coverage |
There was a problem hiding this comment.
dotnet test will still run an implicit restore unless --no-restore is also specified. Since there’s already a dedicated restore step, consider using --no-build --no-restore on the test command to avoid redundant restore work.
Suggested change
| run: dotnet test EasySourceGenerators.sln --no-build --verbosity normal --collect:"XPlat Code Coverage" --logger "trx;LogFilePrefix=test-results" --results-directory ./coverage | |
| run: dotnet test EasySourceGenerators.sln --no-build --no-restore --verbosity normal --collect:"XPlat Code Coverage" --logger "trx;LogFilePrefix=test-results" --results-directory ./coverage |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CI was going straight from
dotnet restoretodotnet test, which implicitly builds only test-reachable projects. An explicit build step ensures the entire solution compiles.dotnet build EasySourceGenerators.sln --no-restorestep between restore and test--no-restoreto--no-buildto avoid redundant recompilation