Skip to content

Conversation

@BenGardiner
Copy link
Collaborator

✨ Enhancements

with this any python-can tool can use a RP1210 adapter

👀 Checklist

  • Did you test your changes?

yes; with scapy.automotive and can.logger using both NXULNK32:1 and DGDPA5MA as -c arguments to -i rp2110

  • Do the unit tests all pass? Y
  • Do the examples still work? Y
  • Are there any failing workflows? N
  • Is version in setup up-to-date? I don't know... I guess if you accept this then it would probably be another version bump...

@dfieschko
Copy link
Owner

Wow, awesome! Thanks for providing this.

@BenGardiner
Copy link
Collaborator Author

Wow, awesome! Thanks for providing this.

Hey my pleasure !

Is there anything in the way of merging this? It's certainly possible that I got the setup.py paths wrong ...

@dfieschko dfieschko merged commit f07a74f into dfieschko:main Jun 1, 2024
@zariiii9003
Copy link

@BenGardiner You could add this to the python-can docs and add it as an optional dependendy in python-can

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants