Conversation
|
|
michael-weigelt
approved these changes
May 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change allows for repeated scopes to be used in canbench benchmarks. Previously the code would straight up refuse to have a similarly named scope -- I think this is a mistake, there are very valid scenarios (example case from stable structures) where someone might have a loop and they want to declare a scope inside it to measure some operation.
People should already be careful not declaring the same names for unrelated scopes, so I don't think a protection against it is worth it (that's I guess the main reason for this restriction currently) and the extra benefit you get to measure things inside loops (which can usually be where heavier parts of processing happens) outweighs some risk that someone re-uses the same name of scope.