Skip to content

Opt subtyping: Restrict going via constituent rule#137

Merged
nomeata merged 1 commit intomasterfrom
joachim/restrict-opt-constituent
Nov 17, 2020
Merged

Opt subtyping: Restrict going via constituent rule#137
nomeata merged 1 commit intomasterfrom
joachim/restrict-opt-constituent

Conversation

@nomeata
Copy link
Copy Markdown
Contributor

@nomeata nomeata commented Nov 17, 2020

this fixes #135

@nomeata nomeata requested a review from rossberg November 17, 2020 14:19
nomeata added a commit that referenced this pull request Nov 17, 2020
this updates the test suite as per
#137
and implements them (in a shoddy way)
@nomeata nomeata merged commit 30f719f into master Nov 17, 2020
@nomeata nomeata deleted the joachim/restrict-opt-constituent branch November 17, 2020 16:20
nomeata added a commit that referenced this pull request Nov 21, 2020
this adds some tests to account for the new behaviour of
#110 and #128 and #134 and #137.

Co-authored-by: chenyan-dfinity <yan.chen@dfinity.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Subtyping: specialised to constituent type and “fix opt” introduce inconsistencies

2 participants