Skip to content

Make encoding functions public #322

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chenyan-dfinity merged 3 commits into from
Mar 10, 2022
Merged

Make encoding functions public #322

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b298fe7
make encoding functions public
seniorjoinu Mar 8, 2022
02cb689
hide internal APIs from docs
seniorjoinu Mar 10, 2022
1a621b6
fmt fix
seniorjoinu Mar 10, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 8 additions & 7 deletions rust/candid/src/ser.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,11 +83,13 @@ impl ValueSerializer {
pub fn get_result(&self) -> &[u8] {
&self.value
}
fn write_leb128(&mut self, value: u64) -> Result<()> {
#[doc(hidden)]
pub fn write_leb128(&mut self, value: u64) -> Result<()> {
leb128_encode(&mut self.value, value)?;
Ok(())
}
fn write(&mut self, bytes: &[u8]) -> Result<()> {
#[doc(hidden)]
pub fn write(&mut self, bytes: &[u8]) -> Result<()> {
use std::io::Write;
self.value.write_all(bytes)?;
Ok(())
Expand Down Expand Up @@ -335,12 +337,11 @@ impl TypeSerialize {
self.type_table[idx] = buf;
Ok(())
}

fn push_type(&mut self, t: &Type) -> Result<()> {
#[doc(hidden)]
pub fn push_type(&mut self, t: &Type) -> Result<()> {
self.args.push(t.clone());
self.build_type(t)
}

fn encode(&self, buf: &mut Vec<u8>, t: &Type) -> Result<()> {
if let Type::Var(id) = t {
let actual_type = self.env.rec_find_type(id)?;
Expand Down Expand Up @@ -393,8 +394,8 @@ impl TypeSerialize {
}?;
Ok(())
}

fn serialize(&mut self) -> Result<()> {
#[doc(hidden)]
pub fn serialize(&mut self) -> Result<()> {
leb128_encode(&mut self.result, self.type_table.len() as u64)?;
self.result.append(&mut self.type_table.concat());

Expand Down