Conversation
github-actions
Bot
force-pushed
the
release-plz-2026-01-30T12-37-30Z
branch
from
065bd0a to
22cf222
Compare
gregorydemay
left a comment
gregorydemay
left a comment
There was a problem hiding this comment.
Thanks for creating the release, a minor comment about the verisoning of ic-agent-canister-runtime
| The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.1.0/), | ||
| and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html). | ||
|
|
||
| ## [0.1.2] - 2026-01-30 |
There was a problem hiding this comment.
why increasing the patch number? AFAIK this is not a bug fix release so I would go with 0.2.0.
There was a problem hiding this comment.
Good question. I generally try to avoid bumping the major version for such a small change (just dependency updates here) since this breaks Cargo compatibility. From the docs:
This guide uses the terms “major” and “minor” assuming this relates to a “1.0.0” release or later. Initial development releases starting with “0.y.z” can treat changes in “y” as a major release, and “z” as a minor release. “0.0.z” releases are always major changes. This is because Cargo uses the convention that only changes in the left-most non-zero component are considered incompatible.
According to semver.org though:
Major version zero (0.y.z) is for initial development. Anything MAY change at any time. The public API SHOULD NOT be considered stable.
I guess the right thing to do would be to just bump to v1.0.0 here sooner rather than later... WDYT?
There was a problem hiding this comment.
I see, thanks for the explanation! Let's follow the more specific guidelines from Cargo then. I think we should bump everything to v1 once we have JSON-RPC batch used in the EVM RPC canister, WDYT?
2 participants
🤖 New release
canhttp: 0.4.0 -> 0.5.0 (✓ API compatible changes)ic-canister-runtime: 0.1.1 -> 0.1.2 (✓ API compatible changes)ic-pocket-canister-runtime: 0.2.0 -> 0.3.0 (⚠ API breaking changes)ic-agent-canister-runtime: 0.1.1 -> 0.1.2 (✓ API compatible changes)Changelog
canhttpic-canister-runtimeic-pocket-canister-runtimeic-agent-canister-runtimeThis PR was generated with release-plz.